Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove org context switcher in the cli#13674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 14 commits intomainfromstevenmasley/unified_org_cli
Jul 1, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedJun 26, 2024
edited
Loading

What this does

Removes the cli organization switcher. All commands that require an organization context default to an organization if the user is only in 1 org. Multi org users require settingCODER_ORGANIZATION=<org> or--org=<organization> (-O=<organization> shorthand)

Future Work

Ideally we could remove the organization context required from many of the template related commands if the template name is unambiguous. At present, the organization ID is required for the fetching template API.

  • Remove from templates list command
  • Add organization columns to relevant resources for cli listing

Kira-Pilot reacted with hooray emoji
@EmyrkEmyrkforce-pushed thestevenmasley/unified_org_cli branch fromd0e9124 to2917474CompareJune 26, 2024 18:01
@EmyrkEmyrk marked this pull request as ready for reviewJune 26, 2024 21:25
@EmyrkEmyrk requested review fromaslilacJune 28, 2024 15:01
cli/root.go Outdated
// Otherwise, we can assume a default value.
Required: false,
Flag: "org",
FlagShorthand: "z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

-z is a really weird choice here imo. I know-o is used, but what about-O? just doesn't feel like there is very clear connection.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was thinking organiZation lol. I can switch to-O

Kira-Pilot reacted with laugh emoji
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you 😄

@EmyrkEmyrk merged commit5bf46f3 intomainJul 1, 2024
29 checks passed
@EmyrkEmyrk deleted the stevenmasley/unified_org_cli branchJuly 1, 2024 21:04
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp