Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: disable agent app buttons while a blocking startup script is running#13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromapps-wait-for-ready
Jun 27, 2024

Conversation

aslilac
Copy link
Member

From a customer in Zendesk (loosely paraphrased)

The behavior we would like to have is forcoder_app​ resources tonot be accessible until after the startup script has completed. To do this, I've set startup_script_behavior​ to "blocking"​ in our templates. Thestartup_script_behavior documentation, says this means that the workspace is "not ready", which I would expect to mean that you can't yet do things like click on apps.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm missing a test to ensure we don't change this in the future accidentally.

@aslilacaslilac merged commit8b615f4 intomainJun 27, 2024
29 checks passed
@aslilacaslilac deleted the apps-wait-for-ready branchJune 27, 2024 17:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp