Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: test with multiple postgres versions#13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 10 commits intomainfromcj/postgres-16
Jun 26, 2024
Merged

ci: test with multiple postgres versions#13665

johnstcn merged 10 commits intomainfromcj/postgres-16
Jun 26, 2024

Conversation

@johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 25, 2024•
edited
Loading

  • Tests now run on postgres 16 by default when run locally (can be specified withPOSTGRES_VERSION)
  • Addstest-go-pg-16 to test against postgres version 16
  • Updates Dogfood dockerfile / nix flake to postgres version 16
  • Updatesdocker-compose.yaml postgres tag to 16

@johnstcnjohnstcn self-assigned thisJun 25, 2024
@johnstcnjohnstcn marked this pull request as ready for reviewJune 25, 2024 18:55
@johnstcnjohnstcn changed the titlechore(Makefile): use postgres 16 for testsci: test with multiple postgres versionsJun 26, 2024
@matifali
Copy link
Member

Should we bump postgress version in dogfood Dockerfile and nix.flake too?

johnstcn reacted with thumbs up emoji

@matifali
Copy link
Member

Also you may like to answer#13438.

@johnstcn
Copy link
MemberAuthor

I'm going to leave our embedded postgres version at 13; updating that with no warning may cause sadness.

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Are we asking customers to upgrade to 16?

@johnstcn
Copy link
MemberAuthor

👍 Are we asking customers to upgrade to 16?

Nope, folks are asking if 16 is supported.

Emyrk reacted with thumbs up emoji

@johnstcnjohnstcn merged commit20e59e0 intomainJun 26, 2024
@johnstcnjohnstcn deleted the cj/postgres-16 branchJune 26, 2024 15:22
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EmyrkEmyrkEmyrk approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnstcn@matifali@Emyrk@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp