Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add "Full Name" field to user creation#13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/create-user-fullname
Jun 26, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 25, 2024•
edited
Loading

Part of#13490

Continued from#13491

Adds the ability to specify "Full Name" (a.k.a. Name) when creating users either via CLI or UI.

@johnstcnjohnstcn self-assigned thisJun 25, 2024
Adds the ability to specify "Full Name" (a.k.a. Name) whencreating users either via CLI or UI.
@johnstcnjohnstcnforce-pushed thecj/create-user-fullname branch from2e68b76 to0ec27e9CompareJune 25, 2024 12:53
@johnstcnjohnstcn marked this pull request as ready for reviewJune 25, 2024 12:59
@@ -20,6 +21,8 @@ export const Language = {
emailLabel: "Email",
passwordLabel: "Password",
usernameLabel: "Username",
nameLabel: "Full name",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: I would use "Name" instead of "Full name".

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Again, I would much prefer to use "full name" in the UI/CLI to distinguish it from "username". The API refers to it asname however.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

❤️ for adding e2e tests

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good and it is tested 🙏

@johnstcnjohnstcn merged commit8a35925 intomainJun 26, 2024
31 checks passed
@johnstcnjohnstcn deleted the cj/create-user-fullname branchJune 26, 2024 08:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@BrunoQuaresma@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp