Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add Peek() method to mock Clock#13657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/clock-testing-next
Jun 25, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJun 25, 2024•
edited
Loading

Adds aPeek() method to the mock clock, so you can peek at how long until the next tick or timer event without advancing the clock.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJun 25, 2024•
edited
Loading

@spikecurtisspikecurtis requested review fromkylecarbs,mafredri andjohnstcn and removed request forkylecarbsJune 25, 2024 12:26
@spikecurtisspikecurtis marked this pull request as ready for reviewJune 25, 2024 12:26
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Next() implies advancing the clock. How aboutPeek() instead?

@spikecurtisGraphite App
Copy link
ContributorAuthor

I like Peek

@spikecurtisspikecurtisforce-pushed thespike/clock-testing-next branch from93b53f2 tod153c36CompareJune 25, 2024 12:35
@spikecurtisspikecurtis changed the titlefeat: add Next() method to mock Clockfeat: add Peek() method to mock ClockJun 25, 2024
Base automatically changed fromspike/clock-testing-readme-usage tomainJune 25, 2024 12:38
@spikecurtisspikecurtisforce-pushed thespike/clock-testing-next branch fromd153c36 to5fb9cfeCompareJune 25, 2024 12:39
@spikecurtisspikecurtisforce-pushed thespike/clock-testing-next branch from5fb9cfe toefa2738CompareJune 25, 2024 12:39
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJun 25, 2024•
edited
Loading

Merge activity

  • Jun 25, 8:39 AM EDT:Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jun 25, 8:48 AM EDT:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis merged commit46e1c36 intomainJun 25, 2024
27 checks passed
@spikecurtisspikecurtis deleted the spike/clock-testing-next branchJune 25, 2024 12:48
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp