Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: switch ssh session stats based on experiment#13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 8 commits intomainfromf0ssel/ws-stats-experiment
Jun 25, 2024

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedJun 22, 2024
edited
Loading

This changescoderd to only allow a single endpoint to write ssh session data to the DB at a time. Both the CLI and the agent will always report stats, but the agent endpoint will silently drop session stats while the experimentworkspace-usage is enabled. This prevents us from double-counting stats during the migration period.

We will need to give end users sufficient time to update their CLI and extensions before moving this behavior to GA otherwise outdated clients will have their data dropped until they upgrade.

@f0sself0ssel marked this pull request as ready for reviewJune 22, 2024 16:53
@f0sself0ssel requested a review fromjohnstcnJune 24, 2024 16:24
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

}

return""
returncodersdk.UsageAppNameSSH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Letting the zero value mean 'disabled' feels more idiomatic to me, but 'disabled' is way more explicit and better from a user perspective.

Copy link
ContributorAuthor

@f0sself0sselJun 24, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I considered having the default value on the flag bessh and disable reporting if it's manually set to empty string but I wasn't sure if that was explicit enough behavior. I'm thinking in the extensions where we doCODER_SSH_USAGE_APP_NAME="" coder ssh ... I'm worried there may be cases where the empty string get's passed to the CLI as "unset" instead.

@f0sself0ssel merged commitfed668b intomainJun 25, 2024
@f0sself0ssel deleted the f0ssel/ws-stats-experiment branchJune 25, 2024 14:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@f0sself0ssel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f0ssel@johnstcn@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp