Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: remove connected button#13625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromconnected
Jun 21, 2024
Merged

fix: remove connected button#13625

kylecarbs merged 1 commit intomainfromconnected
Jun 21, 2024

Conversation

kylecarbs
Copy link
Member

It didn't make a lot of sense in current form. It will when we improve autostop.

It didn't make a lot of sense in current form. It will when we improve autostop.
@kylecarbskylecarbs self-assigned thisJun 21, 2024
@kylecarbskylecarbs merged commit3ef12ac intomainJun 21, 2024
27 of 29 checks passed
@kylecarbskylecarbs deleted the connected branchJune 21, 2024 15:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 21, 2024
@BrunoQuaresma
Copy link
Collaborator

This part of the code has been quite fragile, and I'm wondering if we should have added tests to ensure the correct behavior before merging it.

@kylecarbs
Copy link
MemberAuthor

Since this is just removing I'm less concerned about that. We can manually test on dev before release.

@BrunoQuaresma
Copy link
Collaborator

My concern is more about future changes and making sure our future selves remember what the correct behavior should be.

@BrunoQuaresma
Copy link
Collaborator

I'm being extra cautious here because we've already introduced a good number of bugs in this component with just simple changes.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@f0sself0sself0ssel approved these changes

@aslilacaslilacAwaiting requested review from aslilac

@stirbystirbyAwaiting requested review from stirby

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@BrunoQuaresma@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp