- Notifications
You must be signed in to change notification settings - Fork926
fix: remove connected button#13625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It didn't make a lot of sense in current form. It will when we improve autostop.
3ef12ac
intomainUh oh!
There was an error while loading.Please reload this page.
This part of the code has been quite fragile, and I'm wondering if we should have added tests to ensure the correct behavior before merging it. |
Since this is just removing I'm less concerned about that. We can manually test on dev before release. |
My concern is more about future changes and making sure our future selves remember what the correct behavior should be. |
I'm being extra cautious here because we've already introduced a good number of bugs in this component with just simple changes. |
It didn't make a lot of sense in current form. It will when we improve autostop.