Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: upgrade Go version to 1.22.4#13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 7 commits intomainfromcj/go1.22.4
Jun 24, 2024
Merged

chore: upgrade Go version to 1.22.4#13623

johnstcn merged 7 commits intomainfromcj/go1.22.4
Jun 24, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 21, 2024
edited
Loading

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?) EDIT: fixed, I just don't know how to nix.

@johnstcnjohnstcn marked this pull request as ready for reviewJune 24, 2024 08:38
@matifali
Copy link
Member

matifali commentedJun 24, 2024
edited
Loading

Some missing places:

  1. go-version:1.21.9
    This was running fmt check with go 1.21, we should perhaps use the common setup-go action and enable caching again. It should make little difference.
johnstcn reacted with heart emoji

@matifali
Copy link
Member

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?)

go 1.22.4 should be available.NixOS/nixpkgs#317326

@johnstcn
Copy link
MemberAuthor

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?)

go 1.22.4 should be available.NixOS/nixpkgs#317326

It still shows up as the older version for me here:https://search.nixos.org/packages?channel=unstable&show=go&from=0&size=50&sort=relevance&type=packages&query=go

I figure it's just a matter of time though.

matifali reacted with thumbs up emoji

@matifali
Copy link
Member

matifali commentedJun 24, 2024
edited
Loading

May be we need to runnix flake update to get the new version.

johnstcnand others added2 commitsJune 24, 2024 13:59
I ran it on my amd64 desktop in a WSL shell on Widows 11.
@matifali
Copy link
Member

@johnstcn I ran the./scripts/update-flake.sh on an amd64 desktop, and now the hash matches.

johnstcn reacted with heart emoji

@johnstcnjohnstcn changed the titlechore: update Go version to 1.22.4chore: upgrade Go version to 1.22.4Jun 24, 2024
@johnstcnjohnstcn merged commitb4a5c7f intomainJun 24, 2024
38 checks passed
@johnstcnjohnstcn deleted the cj/go1.22.4 branchJune 24, 2024 14:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@matifalimatifalimatifali approved these changes

@coadlercoadlerAwaiting requested review from coadler

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@matifali@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp