Codecov Report

Merging#1361 (9bd6ca5) intomain (e54324d) willincrease coverage by0.46%.
The diff coverage is88.63%.

@@            Coverage Diff             @@##             main    #1361      +/-   ##==========================================+ Coverage   66.49%   66.95%   +0.46%==========================================  Files         284      286       +2       Lines       18593    18752     +159       Branches      235      241       +6     ==========================================+ Hits        12363    12555     +192+ Misses       4964     4913      -51- Partials     1266     1284      +18

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee54324d...9bd6ca5. Read thecomment docs.

@presleyp thanks for the review.

About theuseRoles hook. When I have to use an effect + state I like to encapsulate these into a hook, so I can make more explicit what I want to do with them and how they are connected. This article explains some pros of this "pattern" if you are interestedhttps://kyleshevlin.com/use-encapsulation

@BrunoQuaresma yeah, I think that's a strategy for addressing the thing that bothers me aboutuseEffect, which is that it's hard to tell over time what it's meant to do and when it's expected to run. Even with the custom hook, I think it would be helpful to add a comment that send never changes so this should only run on mount.