- Notifications
You must be signed in to change notification settings - Fork926
fix: fill out zero-value user properties in /audit#13604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bf85f1d to5055300Compare5055300 tocb386a0Compare Comment on lines +6 to +7
| -- sqlc.embed(users) would be nice but it does not seem to play well with | ||
| -- left joins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yea, there is a few issues open on this:
https://github.com/sqlc-dev/sqlc/issues?q=is%3Aissue+is%3Aopen+nullable+embed
😢
Emyrk approved these changesJun 20, 2024
All except the organization IDs. We can add this as well if needed, butthe complaint was specifically about last_seen_at.
cb386a0 to1eb189aCompare43e45f4 intomain 26 of 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
All except the organization IDs; those continue to be omitted. We can add the organization IDs as well if needed, but the complaint was specifically about
last_seen_at. Not sure how valuable it is to have the organization IDs.Originally I tried
sqlc.embedbut if the left join ends up with a null then we get an error (not sure if this happens in practice as it looks like users are soft deleted; I manually deleted a user to test the behavior). Maybe there is a clever way to get it working though? At least the test should catch if we make future additions in one spot but not the other.