Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: unify organization and deployment management settings#13602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 17 commits intomainfrommanagement-settings
Jul 1, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJun 18, 2024•
edited
Loading

Screenshot 2024-06-20 at 3 20 07 PM

Improves the organization settings, and brings in the deployment settings to the same view with a shared sidebar for navigation.

@aslilacaslilac changed the titledraft: management settingsfeat: unified organization and deployment management settingsJun 20, 2024
@aslilacaslilac changed the titlefeat: unified organization and deployment management settingsfeat: unify organization and deployment management settingsJun 20, 2024
@aslilacaslilac marked this pull request as ready for reviewJune 20, 2024 20:50
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a few comments related to the code and about tests, since this is an important feature, I would add e2e tests to cover the critical flows:

  • Create a new org
  • Update a org
  • Delete a org

@BrunoQuaresma

This comment was marked as resolved.

@aslilac
Copy link
MemberAuthor

When trying to create an org with an existent name the error is displayed in the top when IMO it should be displayed in the form.

We can adjust that, but that's a backend problem.

BrunoQuaresma reacted with thumbs up emoji

@aslilac
Copy link
MemberAuthor

Left a few comments related to the code and about tests, since this is an important feature, I would add e2e tests to cover the critical flows

It's behind an experiment, so I can't yet. 😅

@aslilac
Copy link
MemberAuthor

actually I guess I can just add it to the env variable in the e2e test config

@aslilacaslilac merged commitd977654 intomainJul 1, 2024
@aslilacaslilac deleted the management-settings branchJuly 1, 2024 17:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp