Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix workspace actions options#13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 4 commits intomainfromfix-workspace-actions
Jun 17, 2024
Merged

Conversation

@aslilac
Copy link
Member

@aslilacaslilac commentedJun 13, 2024•
edited
Loading

Simplify the code a bit to prevent bad states, and add additional stories.

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it is an improvement but I'm not sure if our tests are in place to avoid confusion and unwanted changes in the future.

@aslilac
Copy link
MemberAuthor

I think there should be a story for every code path now.

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the changes. I left two comments in Storybook for your consideration.

@aslilacaslilac merged commit07cd9ac intomainJun 17, 2024
@aslilacaslilac deleted the fix-workspace-actions branchJune 17, 2024 16:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbsAwaiting requested review from kylecarbs

1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp