Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat!: add interface report to coder netcheck#13562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/netcheck-interface-report
Jun 13, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJun 13, 2024
edited
Loading

re:#13327

Adds local interfaces tocoder netcheck and checks their MTUs for potential problems.

This is mostly relevant for end-user systems where VPNs are common. Wecould also add it to coderd healthcheck, but until I see coderd connecting to workspaces over a VPN in the wild, I don't think its worth the UX effort.

Netcheck results get the following:

  "interfaces": {    "error": null,    "severity": "ok",    "warnings": null,    "dismissed": false,    "interfaces": [      {        "name": "lo0",        "mtu": 16384,        "addresses": [          "127.0.0.1/8",          "::1/128",          "fe80::1/64"        ]      },      {        "name": "en8",        "mtu": 1500,        "addresses": [          "192.168.50.217/24",          "fe80::c13:1a92:3fa5:dd7e/64"        ]      }    ]  }

Technically not back compatible if anyone is parsingcoder netcheck output as JSON, since the original output is now under"derp" in the output.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJun 13, 2024
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewJune 13, 2024 04:23
@spikecurtisspikecurtisforce-pushed thespike/netcheck-interface-report branch from94b740d to1b8da82CompareJune 13, 2024 04:36
@spikecurtisspikecurtisforce-pushed thespike/netcheck-interface-report branch from1b8da82 todcebda4CompareJune 13, 2024 04:52
@spikecurtisspikecurtis changed the titlefeat: add interface report to coder netcheckfeat: expand netcheck to include interface details and small MTU warningJun 13, 2024
@spikecurtisspikecurtis changed the titlefeat: expand netcheck to include interface details and small MTU warning!feat: add interface report to coder netcheckJun 13, 2024
@spikecurtisspikecurtis changed the title!feat: add interface report to coder netcheckfeat!: add interface report to coder netcheckJun 13, 2024
@github-actionsgithub-actionsbot added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelJun 13, 2024
@spikecurtisspikecurtis merged commitfc09077 intomainJun 13, 2024
37 checks passed
@spikecurtisspikecurtis deleted the spike/netcheck-interface-report branchJune 13, 2024 06:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

@sreyasreyaAwaiting requested review from sreya

Assignees

@spikecurtisspikecurtis

Labels
release/breakingThis label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp