Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Use proper endpoint for user workspaces#1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromfixws
May 10, 2022
Merged

fix: Use proper endpoint for user workspaces#1356

kylecarbs merged 1 commit intomainfromfixws
May 10, 2022

Conversation

kylecarbs
Copy link
Member

This was a silly mistake in a prior PR, so the code wasn't
actually being called!

This was a silly mistake in a prior PR, so the code wasn'tactually being called!
@kylecarbskylecarbs requested a review fromcoadlerMay 10, 2022 03:00
@kylecarbskylecarbs self-assigned thisMay 10, 2022
@kylecarbskylecarbsenabled auto-merge (squash)May 10, 2022 03:01
@codecov
Copy link

codecovbot commentedMay 10, 2022
edited
Loading

Codecov Report

Merging#1356 (407fbd4) intomain (b675aec) willincrease coverage by0.06%.
The diff coverage is69.56%.

@@            Coverage Diff             @@##             main    #1356      +/-   ##==========================================+ Coverage   66.69%   66.76%   +0.06%==========================================  Files         284      280       -4       Lines       18614    18433     -181       Branches      235      235              ==========================================- Hits        12414    12306     -108+ Misses       4931     4861      -70+ Partials     1269     1266       -3
FlagCoverage Δ
unittest-go-macos-latest54.05% <69.56%> (+0.17%)⬆️
unittest-go-postgres-65.41% <69.56%> (+0.02%)⬆️
unittest-go-ubuntu-latest56.47% <69.56%> (+0.17%)⬆️
unittest-go-windows-2022?
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
coderd/users.go60.63% <68.18%> (+2.23%)⬆️
coderd/coderd.go94.55% <100.00%> (ø)
cli/configssh.go62.58% <0.00%> (-6.48%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
coderd/workspaceagents.go56.04% <0.00%> (-1.87%)⬇️
agent/agent.go64.66% <0.00%> (-1.86%)⬇️
peer/channel.go84.21% <0.00%> (-1.76%)⬇️
peer/conn.go78.37% <0.00%> (-1.72%)⬇️
coderd/organizations.go56.15% <0.00%> (-0.55%)⬇️
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb675aec...407fbd4. Read thecomment docs.

@kylecarbskylecarbs merged commitdc115b8 intomainMay 10, 2022
@kylecarbskylecarbs deleted the fixws branchMay 10, 2022 03:10
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This was a silly mistake in a prior PR, so the code wasn'tactually being called!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@coadler@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp