- Notifications
You must be signed in to change notification settings - Fork927
chore: implement assign organization roles from the cli#13558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Emyrk commentedJun 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
b665268 toa6744b3Comparedfded68 to1b3a9b7Comparea6744b3 toeacff69Compare1b3a9b7 toe605d37Compareeacff69 to979b3d8Comparee605d37 tod23e335Compare979b3d8 to45f4baaCompared23e335 to9c1fda7Compare45f4baa to46067a6Compare9c1fda7 to0012858Compare46067a6 to7d98e6cCompareec0f038 to24409b0Compare| @@ -11,16 +12,74 @@ import ( | |||
| ) | |||
| func (r *RootCmd) organizationMembers() *serpent.Command { | |||
| cmd := &serpent.Command{ | |||
| Use: "members", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this ready for end users to start consuming? If not, do we want to start with it hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is not, but the parent command is hidden:
Line 24 ina8fe429
| Hidden:true,// Hidden until these commands are complete. |
So this is also hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice 👍
cli/organizationmembers.go Outdated
| userIdentifier := inv.Args[0] | ||
| member, err := client.UpdateOrganizationMemberRoles(ctx, organization.ID, userIdentifier, codersdk.UpdateRoles{ | ||
| Roles: inv.Args[1:], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: I would prefer this be declared as a variable underuserIdentifier to be slightly more readable, but dealers choice.
Basic functionality to assign roles to an organization member via cli.
24409b0 to946a3acCompare7d51515 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Basic functionality to assign roles to an organization member via cli.