NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: implement cli list organization members#13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 3 commits intomainfromstevenmasley/org_member_cli

Jun 12, 2024

Merged

chore: implement cli list organization members#13555

Emyrk merged 3 commits intomainfromstevenmasley/org_member_cli

Jun 12, 2024

Conversation

Copy link

Member

Emyrk commentedJun 12, 2024•
edited
Loading

coder organization members -c username,user_id,organization_roles USERNAME        USER ID                               ORGANIZATION ROLES                 busy-borg3-7M4  342c188b-40e9-4fd9-b678-ff83be5e5114  [Custom Role, Organization Admin]  testuser        b60a10bb-f03b-48d9-b395-a6f9f3eac76f  []

github-actionsbot assignedEmyrk

Jun 12, 2024

Emyrk mentioned this pull request

Jun 12, 2024

chore: merge organization member db queries#13542

Merged

Copy link

MemberAuthor

Emyrk commentedJun 12, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@Emyrk and the rest of your teammates onGraphite

This was referencedJun 12, 2024

chore: implement api layer for listing organization members#13546

Merged

Add ability to create custom roles for site + orgs#13226

Closed

Emyrk force-pushed thestevenmasley/org_member_cli branch 2 times, most recently fromb64c69b todfded68Compare

June 12, 2024 16:30

Emyrk marked this pull request as ready for review

June 12, 2024 16:41

Emyrk requested a review fromf0ssel

June 12, 2024 16:49

Emyrk mentioned this pull request

Jun 12, 2024

chore: implement assign organization roles from the cli#13558

Merged

f0ssel approved these changes

Jun 12, 2024

View reviewed changes

Copy link

Contributor

f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

all stacks look good so far and make sense to me

coderd/members.go

		OrganizationID: uuid.UUID{},
		})
		if err != nil {
		// We are missing the display names, but that is not absolutely required. So just

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we expecting an error here? I see wecan do without it, but I wonder if we should instead of just presenting the error?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll return the error 👍

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just unfortunate we can block api calls on this kind of error. Would be nice if we could return some sort of "warning" instead. I'll return an error though as that is what we usually do for failed db calls.