- Notifications
You must be signed in to change notification settings - Fork921
feat: lint github actions workflows#13552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
.github/workflows/ci.yaml Outdated
| @@ -191,6 +191,12 @@ jobs: | |||
| run: | | |||
| make --output-sync=line -j lint | |||
| - name: Check workflow files | |||
| run: | | |||
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) | |
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) 1.7.1 |
This will make it easier to bump versions while pinning the version.
ref:https://github.com/rhysd/actionlint/blob/main/docs/install.md#download-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea 👍 I've pinned to1.6.22 which is the version to which the current commit is pointing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest we pin to latest availbale just to be sure that linter supports any newly added syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we do so, we should update code-server too. Seehttps://github.com/coder/code-server/blob/main/.github/workflows/build.yaml#L142-L152.
@kylecarbs any objections?
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
d5d8b91 intomainUh oh!
There was an error while loading.Please reload this page.
Copied fromhttps://github.com/coder/code-server/blob/0c802ba1652296c79d26ff3e990578e67e6734b1/.github/workflows/build.yaml#L142-L152
Fixes#13413
Credit to@matifali for finding out how we do this already.