Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Allow coderd to exit on error channel#1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromsurfaceerror
May 10, 2022
Merged

Conversation

kylecarbs
Copy link
Member

coderd would fail silently if this was called, because connections
would never drain. HashiCorp's hc-install package broke today,
and we couldn't notice because this was hanging!

coderd would fail silently if this was called, because connectionswould never drain. HashiCorp's hc-install package broke today,and we couldn't notice because this was hanging!
@kylecarbskylecarbs requested a review fromcoadlerMay 10, 2022 02:07
@kylecarbskylecarbs self-assigned thisMay 10, 2022
@kylecarbskylecarbsenabled auto-merge (squash)May 10, 2022 02:09
@codecov
Copy link

codecovbot commentedMay 10, 2022•
edited
Loading

Codecov Report

Merging#1355 (320110c) intomain (3660483) willdecrease coverage by0.20%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main    #1355      +/-   ##==========================================- Coverage   67.03%   66.83%   -0.21%==========================================  Files         284      280       -4       Lines       18529    18330     -199       Branches      235      235              ==========================================- Hits        12421    12250     -171+ Misses       4844     4826      -18+ Partials     1264     1254      -10
FlagCoverage Δ
unittest-go-macos-latest54.06% <0.00%> (-0.20%)⬇️
unittest-go-postgres-65.61% <0.00%> (-0.12%)⬇️
unittest-go-ubuntu-latest56.59% <0.00%> (-0.04%)⬇️
unittest-go-windows-2022?
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
cli/server.go57.48% <0.00%> (-0.10%)⬇️
cli/configssh.go62.58% <0.00%> (-6.48%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/cliui/agent.go77.46% <0.00%> (-4.23%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
peer/conn.go79.85% <0.00%> (-2.71%)⬇️
agent/agent.go64.66% <0.00%> (-2.48%)⬇️
provisioner/echo/serve.go54.40% <0.00%> (-2.40%)⬇️
coderd/workspaceagents.go56.04% <0.00%> (-1.87%)⬇️
provisionerd/provisionerd.go75.76% <0.00%> (-0.54%)⬇️
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3660483...320110c. Read thecomment docs.

@kylecarbskylecarbs merged commite6f1ce1 intomainMay 10, 2022
@kylecarbskylecarbs deleted the surfaceerror branchMay 10, 2022 02:19
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs added a commit that referenced this pull requestJun 10, 2022
coderd would fail silently if this was called, because connectionswould never drain. HashiCorp's hc-install package broke today,and we couldn't notice because this was hanging!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@coadler@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp