- Notifications
You must be signed in to change notification settings - Fork1k
refactor(site): refactor filter search field#13545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import type { Meta, StoryObj } from "@storybook/react"; | ||
| import { userEvent, within } from "@storybook/test"; | ||
| import { useState } from "react"; | ||
| import { SearchField } from "./SearchField"; | ||
| const meta: Meta<typeof SearchField> = { | ||
| title: "components/SearchField", | ||
| component: SearchField, | ||
| args: { | ||
| placeholder: "Search...", | ||
| }, | ||
| render: function StatefulWrapper(args) { | ||
| const [value, setValue] = useState(args.value); | ||
| return <SearchField {...args} value={value} onChange={setValue} />; | ||
| }, | ||
| }; | ||
| export default meta; | ||
| type Story = StoryObj<typeof SearchField>; | ||
| export const Empty: Story = {}; | ||
| export const DefaultValue: Story = { | ||
| args: { | ||
| value: "owner:me", | ||
| }, | ||
| }; | ||
| export const TypeValue: Story = { | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement); | ||
| const input = canvas.getByRole("textbox"); | ||
| await userEvent.type(input, "owner:me"); | ||
| }, | ||
| }; | ||
| export const ClearValue: Story = { | ||
| args: { | ||
| value: "owner:me", | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement); | ||
| await userEvent.click(canvas.getByRole("button", { name: "Clear field" })); | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { useTheme } from "@emotion/react"; | ||
| import CloseIcon from "@mui/icons-material/CloseOutlined"; | ||
| import SearchIcon from "@mui/icons-material/SearchOutlined"; | ||
| import IconButton from "@mui/material/IconButton"; | ||
| import InputAdornment from "@mui/material/InputAdornment"; | ||
| import TextField, { type TextFieldProps } from "@mui/material/TextField"; | ||
| import Tooltip from "@mui/material/Tooltip"; | ||
| import visuallyHidden from "@mui/utils/visuallyHidden"; | ||
| import type { FC } from "react"; | ||
| export type SearchFieldProps = Omit<TextFieldProps, "onChange"> & { | ||
| onChange: (query: string) => void; | ||
| }; | ||
| export const SearchField: FC<SearchFieldProps> = ({ | ||
| value = "", | ||
| onChange, | ||
| InputProps, | ||
| ...textFieldProps | ||
| }) => { | ||
| const theme = useTheme(); | ||
| return ( | ||
| <TextField | ||
| size="small" | ||
| value={value} | ||
| onChange={(e) => onChange(e.target.value)} | ||
| InputProps={{ | ||
| startAdornment: ( | ||
| <InputAdornment position="start"> | ||
| <SearchIcon | ||
| css={{ | ||
| fontSize: 14, | ||
| color: theme.palette.text.secondary, | ||
| }} | ||
| /> | ||
| </InputAdornment> | ||
| ), | ||
| endAdornment: value !== "" && ( | ||
| <InputAdornment position="end"> | ||
| <Tooltip title="Clear field"> | ||
| <IconButton | ||
| size="small" | ||
| onClick={() => { | ||
| onChange(""); | ||
| }} | ||
| > | ||
| <CloseIcon css={{ fontSize: 14 }} /> | ||
| <span css={{ ...visuallyHidden }}>Clear field</span> | ||
| </IconButton> | ||
| </Tooltip> | ||
| </InputAdornment> | ||
| ), | ||
| ...InputProps, | ||
| }} | ||
| {...textFieldProps} | ||
| /> | ||
| ); | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.