Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add endpoint to get all workspaces a user can access#1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromworkspaces
May 10, 2022

Conversation

kylecarbs
Copy link
Member

This iterates through user organizations to get permitted
workspaces. This will allow admins to manage user workspaces!

@kylecarbskylecarbs requested a review fromcoadlerMay 10, 2022 00:48
@kylecarbskylecarbs self-assigned thisMay 10, 2022
@codecov
Copy link

codecovbot commentedMay 10, 2022
edited
Loading

Codecov Report

Merging#1354 (49be7c5) intomain (3660483) willdecrease coverage by0.30%.
The diff coverage is8.33%.

@@            Coverage Diff             @@##             main    #1354      +/-   ##==========================================- Coverage   67.03%   66.73%   -0.31%==========================================  Files         284      284                Lines       18529    18614      +85       Branches      235      235              ==========================================+ Hits        12421    12422       +1- Misses       4844     4925      +81- Partials     1264     1267       +3
FlagCoverage Δ
unittest-go-macos-latest53.96% <8.33%> (-0.31%)⬇️
unittest-go-postgres-65.34% <8.33%> (-0.39%)⬇️
unittest-go-ubuntu-latest56.40% <8.33%> (-0.24%)⬇️
unittest-go-windows-202252.28% <8.33%> (-0.24%)⬇️
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
coderd/database/queries.sql.go76.73% <0.00%> (-1.42%)⬇️
coderd/users.go58.40% <0.00%> (-3.35%)⬇️
codersdk/users.go64.40% <50.00%> (-0.78%)⬇️
coderd/coderd.go94.55% <100.00%> (+0.02%)⬆️
peer/conn.go80.34% <0.00%> (-2.22%)⬇️
coderd/workspaceagents.go56.04% <0.00%> (-1.87%)⬇️
provisionerd/provisionerd.go75.90% <0.00%> (-0.41%)⬇️
cli/server.go57.48% <0.00%> (-0.10%)⬇️
peerbroker/listen.go87.39% <0.00%> (ø)
coderd/provisionerdaemons.go63.48% <0.00%> (+0.50%)⬆️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3660483...49be7c5. Read thecomment docs.

@@ -56,6 +56,7 @@ require (
github.com/fatedier/frp v0.42.0
github.com/fatedier/golib v0.1.1-0.20220321042308-c306138b83ac
github.com/fatih/color v1.13.0
github.com/fatih/structs v1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oopsie, i mightve forgotten to go mod tidy. we should have a ci step for this, i'll do it in a bit

kylecarbs reacted with thumbs up emoji
@@ -1,279 +0,0 @@
package main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I imagine this is unrelated

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is, but figured I'd clean it up in here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yup, makes sense

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Correct. Figured it was easier to remove this here. It hasn't been used in forever, and is kinda sketchy code.

This iterates through user organizations to get permittedworkspaces. This will allow admins to manage user workspaces!
@kylecarbskylecarbsenabled auto-merge (squash)May 10, 2022 02:23
@kylecarbskylecarbs merged commitb675aec intomainMay 10, 2022
@kylecarbskylecarbs deleted the workspaces branchMay 10, 2022 02:38
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This iterates through user organizations to get permittedworkspaces. This will allow admins to manage user workspaces!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@coadler@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp