- Notifications
You must be signed in to change notification settings - Fork1k
feat: implement thin vertical slice of system-generated notifications#13537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
30 commits Select commitHold shift + click to select a range
53c9cbb
feat: system-generated notifications
dannykopping4856aed
Fixing lint errors & minor tests
dannykoppingcda6efb
Fixing dbauthz test
dannykopping86f937a
TestBufferedUpdates does not need a real db, altering test details sl…
dannykoppinge8f1af2
Correct TestBufferedUpdates to count updated entries, use real db again
dannykoppinga056f54
Use UUID for notifier IDs
dannykopping8c64d30
Small improvements from review suggestions
dannykoppingac149ec
Protect notifiers from modification during Stop()
dannykopping884fadf
Split out enqueuer as separate responsibility, get rid of singleton
dannykopping4e362e7
Remove unnecessary handler registry
dannykopping8097290
Remove unused context
dannykopping1b841ad
Centralise markdown rendering
dannykopping61f5bd6
Appease the linter
dannykopping3c8e33b
Only enqueue notification when not initiated by self
dannykopping757327c
Hide config flags which are unlikely to be modified by operators
dannykopping6f909ae
Remove unnecessary Labels struct
dannykopping36698c5
Enable experiment as safe
dannykoppingc5701a6
Correcting bad refactor
dannykopping9d4c312
Initialize Enqueuer on API startup
dannykopping9380d8e
Only start one notifier since all dispatches are concurrent anyway
dannykopping4b7214d
Fix docs
dannykopping6679ef1
Fix lint error
dannykopping337997d
Merge branch 'main' of github.com:/coder/coder into dk/system-notific…
dannykoppingba5f7c6
Merge branch 'main' of github.com:/coder/coder into dk/system-notific…
dannykopping0f29293
Review feedback
dannykopping7c6c486
Merge branch 'main' of github.com:/coder/coder into dk/system-notific…
dannykoppingc6e75c2
Fix lint failures
dannykoppingaff9e6c
Review comments
dannykopping613e074
Avoid race by exposing number of pending updates
dannykoppingfaea7fc
Merge branch 'main' of github.com:/coder/coder into dk/system-notific…
dannykoppingFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'main' of github.com:/coder/coder into dk/system-notific…
…ations-lib
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitba5f7c6ff1c28377d28432f78d428225a08f137a
There are no files selected for viewing
1 change: 1 addition & 0 deletionscoderd/coderd.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionflake.nix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view thefull changes here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.