Jul 8, 2024 · Jun 11, 2024 · Jun 11, 2024 · Jun 11, 2024 · Jun 11, 2024 · Jun 12, 2024
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 "github.com/open-policy-agent/opa/topdown"

 "cdr.dev/slog"

 "github.com/coder/coder/v2/coderd/rbac/policy"
 "github.com/coder/coder/v2/coderd/rbac/rolestore"

 return q.db.GetLogoURL(ctx)
 }

 func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg database.GetNotificationMessagesByStatusParams) ([]database.NotificationMessage, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 return nil, err
 }
 return q.db.GetNotificationMessagesByStatus(ctx, arg)
 }

 func (q *querier) GetOAuth2ProviderAppByID(ctx context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceOauth2App); err != nil {
 return database.OAuth2ProviderApp{}, err
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
 }

 // Mimic mutation in database query.
 nm.UpdatedAt = sql.NullTime{Time:time.Now(), Valid: true}
 nm.UpdatedAt = sql.NullTime{Time:dbtime.Now(), Valid: true}
 nm.Status = database.NotificationMessageStatusLeased
 nm.StatusReason = sql.NullString{String: fmt.Sprintf("Enqueued by notifier %d", arg.NotifierID), Valid: true}
 nm.LeasedUntil = sql.NullTime{Time:time.Now().Add(time.Second * time.Duration(arg.LeaseSeconds)), Valid: true}
 nm.LeasedUntil = sql.NullTime{Time:dbtime.Now().Add(time.Second * time.Duration(arg.LeaseSeconds)), Valid: true}

 out = append(out, database.AcquireNotificationMessagesRow{
 ID:            nm.ID,
 Targets:                arg.Targets,
 CreatedBy:              arg.CreatedBy,
 // Default fields.
 CreatedAt:time.Now(),
 CreatedAt:dbtime.Now(),
 Status:    database.NotificationMessageStatusPending,
 }

 return q.logoURL, nil
 }

 func (q *FakeQuerier) GetNotificationMessagesByStatus(_ context.Context, arg database.GetNotificationMessagesByStatusParams) ([]database.NotificationMessage, error) {
 err := validateDatabaseType(arg)
 if err != nil {
 return nil, err
 }

 var out []database.NotificationMessage
 for _, m := range q.notificationMessages {
 if len(out) > int(arg.Limit) {
 return out, nil
 }

 if m.Status == arg.Status {
 out = append(out, m)
 }
 }

 return out, nil
 }

 func (q *FakeQuerier) GetOAuth2ProviderAppByID(_ context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
 q.mutex.Lock()
 defer q.mutex.Unlock()
diff --git a/coderd/database/dbmetrics/dbmetrics.go b/coderd/database/dbmetrics/dbmetrics.go
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
diff --git a/coderd/database/migrations/000221_notifications.up.sql b/coderd/database/migrations/000221_notifications.up.sql
 -- TODO: autogenerate constants which reference the UUIDs
 INSERT INTO notification_templates (id, name, title_template, body_template, "group", actions)
 VALUES ('f517da0b-cdc9-410f-ab89-a86107c420ed', 'Workspace Deleted', E'Workspace "{{.Labels.name}}" deleted',
        E'Hi {{.UserName}}\n\nYour workspace **{{.Labels.name}}** was deleted.\nThe specified reason was "**{{.Labels.reason}}**".',
        E'Hi {{.UserName}}\n\nYour workspace **{{.Labels.name}}** was deleted.\nThe specified reason was "**{{.Labels.reason}}{{ if .Labels.initiatedBy }} ({{ .Labels.initiatedBy }}){{end}}**".',
        'Workspace Events', '[
        {
            "label": "View workspaces",
diff --git a/coderd/database/querier.go b/coderd/database/querier.go
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/notifications.sql b/coderd/database/queries/notifications.sql
       FROM notification_messages AS nested
       WHERE nested.updated_at < NOW() - INTERVAL '7 days');

 -- name: GetNotificationMessagesByStatus :many
 SELECT * FROM notification_messages WHERE status = @status LIMIT sqlc.arg('limit')::int;

diff --git a/coderd/notifications/dispatch/smtp.go b/coderd/notifications/dispatch/smtp.go

 "cdr.dev/slog"

 "github.com/coder/coder/v2/coderd/database"
 "github.com/coder/coder/v2/coderd/notifications/render"
 "github.com/coder/coder/v2/coderd/notifications/types"
 markdown "github.com/coder/coder/v2/coderd/render"
 return &SMTPHandler{cfg: cfg, log: log}
 }

 func (*SMTPHandler) NotificationMethod() database.NotificationMethod {
 return database.NotificationMethodSmtp
 }

 func (s *SMTPHandler) Dispatcher(payload types.MessagePayload, titleTmpl, bodyTmpl string) (DeliveryFunc, error) {
 // First render the subject & body into their own discrete strings.
 subject, err := markdown.PlaintextFromMarkdown(titleTmpl)
diff --git a/coderd/notifications/dispatch/webhook.go b/coderd/notifications/dispatch/webhook.go

 "cdr.dev/slog"

 "github.com/coder/coder/v2/coderd/database"
 "github.com/coder/coder/v2/coderd/notifications/types"
 markdown "github.com/coder/coder/v2/coderd/render"
 "github.com/coder/coder/v2/codersdk"
 return &WebhookHandler{cfg: cfg, log: log, cl: &http.Client{}}
 }

 func (*WebhookHandler) NotificationMethod() database.NotificationMethod {
 // TODO: don't use database types
 return database.NotificationMethodWebhook
 }

 func (w *WebhookHandler) Dispatcher(payload types.MessagePayload, titleTmpl, bodyTmpl string) (DeliveryFunc, error) {
 if w.cfg.Endpoint.String() == "" {
 return nil, xerrors.New("webhook endpoint not defined")
diff --git a/coderd/notifications/manager.go b/coderd/notifications/manager.go
 "github.com/coder/coder/v2/codersdk"
 )

 var (
 ErrInvalidDispatchTimeout = xerrors.New("dispatch timeout must be less than lease period")
 )

 // Manager manages all notifications being enqueued and dispatched.
 //
 // Manager maintains a notifier: this consumes the queue of notification messages in the store.
 // helpers is a map of template helpers which are used to customize notification messages to use global settings like
 // access URL etc.
 func NewManager(cfg codersdk.NotificationsConfig, store Store, log slog.Logger) (*Manager, error) {
 // If dispatch timeout exceeds lease period, it is possible that messages can be delivered in duplicate because the
 // lease can expire before the notifier gives up on the dispatch, which results in the message becoming eligible for
 // being re-acquired.
 if cfg.DispatchTimeout.Value() >= cfg.LeasePeriod.Value() {
 return nil, ErrInvalidDispatchTimeout
 }

 return &Manager{
 log:   log,
 cfg:   cfg,
 // Manager requires system-level permissions to interact with the store.
 // Run is only intended to be run once.
 func (m *Manager) Run(ctx context.Context) {
 m.log.Info(ctx, "started")

 m.runOnce.Do(func() {
 // Closes when Stop() is called or context is canceled.
 go func() {
diff --git a/coderd/notifications/manager_test.go b/coderd/notifications/manager_test.go
 "encoding/json"
 "sync/atomic"
 "testing"
 "time"

 "github.com/google/uuid"
 "github.com/stretchr/testify/assert"
 "cdr.dev/slog"
 "cdr.dev/slog/sloggers/slogtest"

 "github.com/coder/coder/v2/coderd/coderdtest"
 "github.com/coder/coder/v2/coderd/database"
 "github.com/coder/coder/v2/coderd/database/dbgen"
 "github.com/coder/coder/v2/coderd/database/dbmem"
 "github.com/coder/coder/v2/coderd/database/dbtestutil"
 "github.com/coder/coder/v2/coderd/notifications"
 if !dbtestutil.WillUsePostgres() {
 t.Skip("This test requires postgres")
 }
 ctx, logger, db, ps := setup(t)
 ctx, logger, db := setup(t)
 interceptor := &bulkUpdateInterceptor{Store: db}

 santa := &santaHandler{}
 enq, err := notifications.NewStoreEnqueuer(cfg, interceptor, defaultHelpers(), logger.Named("notifications-enqueuer"))
 require.NoError(t, err)

 client := coderdtest.New(t, &coderdtest.Options{Database: db, Pubsub: ps})
 user := coderdtest.CreateFirstUser(t, client)
 user := dbgen.User(t, db, database.User{})

 // given
 if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, ""); true {
 require.NoError(t, err)
 }
 if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, ""); true {
 require.NoError(t, err)
 }
 if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "false"}, ""); true {
 require.NoError(t, err)
 }
 _, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, "")
 require.NoError(t, err)
 _, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, "")
 require.NoError(t, err)
 _, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "false"}, "")
 require.NoError(t, err)

 // when
 mgr.Run(ctx)
 "my_url":   func() string { return url },
 }

 ctx := context.Background()
 db := dbmem.New()
 interceptor := newEnqueueInterceptor(db,
 // Inject custom message metadata to influence the payload construction.
 },
 }
 out, err := json.Marshal(actions)
 require.NoError(t, err)
 assert.NoError(t, err)

 return database.FetchNewMessageMetadataRow{
 NotificationName: "My Notification",
 enq, err := notifications.NewStoreEnqueuer(defaultNotificationsConfig(database.NotificationMethodSmtp), interceptor, helpers, logger.Named("notifications-enqueuer"))
 require.NoError(t, err)

 ctx := testutil.Context(t, testutil.WaitShort)

 // when
 _, err = enq.Enqueue(ctx, uuid.New(), notifications.TemplateWorkspaceDeleted, nil, "test")
 require.NoError(t, err)

 // then
 select {
 case payload := <-interceptor.payload:
 require.Len(t, payload.Actions, 1)
 require.Equal(t, label, payload.Actions[0].Label)
 require.Equal(t, url, payload.Actions[0].URL)
 case <-time.After(testutil.WaitShort):
 t.Fatalf("timed out")
 }
 payload := testutil.RequireRecvCtx(ctx, t, interceptor.payload)
 require.Len(t, payload.Actions, 1)
 require.Equal(t, label, payload.Actions[0].Label)
 require.Equal(t, url, payload.Actions[0].URL)
 }

 func TestStopBeforeRun(t *testing.T) {
 nice    atomic.Int32
 }

 func (*santaHandler) NotificationMethod() database.NotificationMethod {
 return database.NotificationMethodSmtp
 }

 func (s *santaHandler) Dispatcher(payload types.MessagePayload, _, _ string) (dispatch.DeliveryFunc, error) {
 return func(ctx context.Context, msgID uuid.UUID) (retryable bool, err error) {
 if payload.Labels["nice"] != "true" {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -17,6 +17,7 @@ import (
		"github.com/open-policy-agent/opa/topdown"

		"cdr.dev/slog"

		"github.com/coder/coder/v2/coderd/rbac/policy"
		"github.com/coder/coder/v2/coderd/rbac/rolestore"

Expand DownExpand Up		@@ -1471,6 +1472,13 @@ func (q *querier) GetLogoURL(ctx context.Context) (string, error) {
		return q.db.GetLogoURL(ctx)
		}

		func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg database.GetNotificationMessagesByStatusParams) ([]database.NotificationMessage, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
		return nil, err
		}
		return q.db.GetNotificationMessagesByStatus(ctx, arg)
		}

		func (q *querier) GetOAuth2ProviderAppByID(ctx context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceOauth2App); err != nil {
		return database.OAuth2ProviderApp{}, err
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -944,10 +944,10 @@ func (q *FakeQuerier) AcquireNotificationMessages(_ context.Context, arg databas
		}

		// Mimic mutation in database query.
		nm.UpdatedAt = sql.NullTime{Time:time.Now(), Valid: true}
		nm.UpdatedAt = sql.NullTime{Time:dbtime.Now(), Valid: true}
		nm.Status = database.NotificationMessageStatusLeased
		nm.StatusReason = sql.NullString{String: fmt.Sprintf("Enqueued by notifier %d", arg.NotifierID), Valid: true}
		nm.LeasedUntil = sql.NullTime{Time:time.Now().Add(time.Second * time.Duration(arg.LeaseSeconds)), Valid: true}
		nm.LeasedUntil = sql.NullTime{Time:dbtime.Now().Add(time.Second * time.Duration(arg.LeaseSeconds)), Valid: true}

		out = append(out, database.AcquireNotificationMessagesRow{
		ID: nm.ID,
Expand DownExpand Up		@@ -1836,7 +1836,7 @@ func (q *FakeQuerier) EnqueueNotificationMessage(_ context.Context, arg database
		Targets: arg.Targets,
		CreatedBy: arg.CreatedBy,
		// Default fields.
		CreatedAt:time.Now(),
		CreatedAt:dbtime.Now(),
		Status: database.NotificationMessageStatusPending,
		}

Expand DownExpand Up		@@ -2740,6 +2740,26 @@ func (q *FakeQuerier) GetLogoURL(_ context.Context) (string, error) {
		return q.logoURL, nil
		}

		func (q *FakeQuerier) GetNotificationMessagesByStatus(_ context.Context, arg database.GetNotificationMessagesByStatusParams) ([]database.NotificationMessage, error) {
		err := validateDatabaseType(arg)
		if err != nil {
		return nil, err
		}

		var out []database.NotificationMessage
		for _, m := range q.notificationMessages {
		if len(out) > int(arg.Limit) {
		return out, nil
		}

		if m.Status == arg.Status {
		out = append(out, m)
		}
		}

		return out, nil
		}

		func (q *FakeQuerier) GetOAuth2ProviderAppByID(_ context.Context, id uuid.UUID) (database.OAuth2ProviderApp, error) {
		q.mutex.Lock()
		defer q.mutex.Unlock()
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -52,7 +52,7 @@ CREATE INDEX idx_notification_messages_status ON notification_messages (status);
		-- TODO: autogenerate constants which reference the UUIDs
		INSERT INTO notification_templates (id, name, title_template, body_template, "group", actions)
		VALUES ('f517da0b-cdc9-410f-ab89-a86107c420ed', 'Workspace Deleted', E'Workspace "{{.Labels.name}}" deleted',
		E'Hi {{.UserName}}\n\nYour workspace {{.Labels.name}} was deleted.\nThe specified reason was "{{.Labels.reason}}".',
		E'Hi {{.UserName}}\n\nYour workspace {{.Labels.name}} was deleted.\nThe specified reason was "{{.Labels.reason}}{{ if .Labels.initiatedBy }} ({{ .Labels.initiatedBy }}){{end}}".',
		'Workspace Events', '[
		{
		"label": "View workspaces",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -125,3 +125,6 @@ WHERE id IN
		FROM notification_messages AS nested
		WHERE nested.updated_at < NOW() - INTERVAL '7 days');

		-- name: GetNotificationMessagesByStatus :many
		SELECT * FROM notification_messages WHERE status = @status LIMIT sqlc.arg('limit')::int;
mtojek marked this conversation as resolved. Show resolvedHide resolved
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,7 +20,6 @@ import (

		"cdr.dev/slog"

		"github.com/coder/coder/v2/coderd/database"
		"github.com/coder/coder/v2/coderd/notifications/render"
		"github.com/coder/coder/v2/coderd/notifications/types"
		markdown "github.com/coder/coder/v2/coderd/render"
Expand DownExpand Up		@@ -53,10 +52,6 @@ func NewSMTPHandler(cfg codersdk.NotificationsEmailConfig, log slog.Logger) *SMT
		return &SMTPHandler{cfg: cfg, log: log}
		}

		func (*SMTPHandler) NotificationMethod() database.NotificationMethod {
		return database.NotificationMethodSmtp
		}

		func (s *SMTPHandler) Dispatcher(payload types.MessagePayload, titleTmpl, bodyTmpl string) (DeliveryFunc, error) {
		// First render the subject & body into their own discrete strings.
		subject, err := markdown.PlaintextFromMarkdown(titleTmpl)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,7 +13,6 @@ import (

		"cdr.dev/slog"

		"github.com/coder/coder/v2/coderd/database"
		"github.com/coder/coder/v2/coderd/notifications/types"
		markdown "github.com/coder/coder/v2/coderd/render"
		"github.com/coder/coder/v2/codersdk"
Expand All		@@ -40,11 +39,6 @@ func NewWebhookHandler(cfg codersdk.NotificationsWebhookConfig, log slog.Logger)
		return &WebhookHandler{cfg: cfg, log: log, cl: &http.Client{}}
dannykopping marked this conversation as resolved. Show resolvedHide resolved
		}

		func (*WebhookHandler) NotificationMethod() database.NotificationMethod {
		// TODO: don't use database types
		return database.NotificationMethodWebhook
		}

		func (w *WebhookHandler) Dispatcher(payload types.MessagePayload, titleTmpl, bodyTmpl string) (DeliveryFunc, error) {
		if w.cfg.Endpoint.String() == "" {
		return nil, xerrors.New("webhook endpoint not defined")
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,6 +16,10 @@ import (
		"github.com/coder/coder/v2/codersdk"
		)

		var (
		ErrInvalidDispatchTimeout = xerrors.New("dispatch timeout must be less than lease period")
		)

		// Manager manages all notifications being enqueued and dispatched.
		//
		// Manager maintains a notifier: this consumes the queue of notification messages in the store.
Expand DownExpand Up		@@ -53,6 +57,13 @@ type Manager struct {
		// helpers is a map of template helpers which are used to customize notification messages to use global settings like
		// access URL etc.
		func NewManager(cfg codersdk.NotificationsConfig, store Store, log slog.Logger) (*Manager, error) {
		// If dispatch timeout exceeds lease period, it is possible that messages can be delivered in duplicate because the
		// lease can expire before the notifier gives up on the dispatch, which results in the message becoming eligible for
		// being re-acquired.
		if cfg.DispatchTimeout.Value() >= cfg.LeasePeriod.Value() {
		return nil, ErrInvalidDispatchTimeout
		}

		return &Manager{
		log: log,
		cfg: cfg,
Expand DownExpand Up		@@ -82,6 +93,8 @@ func (m *Manager) WithHandlers(reg map[database.NotificationMethod]Handler) {
		// Manager requires system-level permissions to interact with the store.
		// Run is only intended to be run once.
		func (m *Manager) Run(ctx context.Context) {
		m.log.Info(ctx, "started")

		m.runOnce.Do(func() {
		// Closes when Stop() is called or context is canceled.
		go func() {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,7 +5,6 @@ import (
		"encoding/json"
		"sync/atomic"
		"testing"
		"time"

		"github.com/google/uuid"
		"github.com/stretchr/testify/assert"
Expand All		@@ -15,8 +14,8 @@ import (
		"cdr.dev/slog"
		"cdr.dev/slog/sloggers/slogtest"

		"github.com/coder/coder/v2/coderd/coderdtest"
		"github.com/coder/coder/v2/coderd/database"
		"github.com/coder/coder/v2/coderd/database/dbgen"
		"github.com/coder/coder/v2/coderd/database/dbmem"
		"github.com/coder/coder/v2/coderd/database/dbtestutil"
		"github.com/coder/coder/v2/coderd/notifications"
Expand All		@@ -32,7 +31,7 @@ func TestBufferedUpdates(t *testing.T) {
		if !dbtestutil.WillUsePostgres() {
		t.Skip("This test requires postgres")
spikecurtis marked this conversation as resolved. Show resolvedHide resolved
		}
		ctx, logger, db, ps := setup(t)
		ctx, logger, db := setup(t)
		interceptor := &bulkUpdateInterceptor{Store: db}

		santa := &santaHandler{}
Expand All		@@ -45,19 +44,15 @@ func TestBufferedUpdates(t *testing.T) {
		enq, err := notifications.NewStoreEnqueuer(cfg, interceptor, defaultHelpers(), logger.Named("notifications-enqueuer"))
		require.NoError(t, err)

		client := coderdtest.New(t, &coderdtest.Options{Database: db, Pubsub: ps})
		user := coderdtest.CreateFirstUser(t, client)
		user := dbgen.User(t, db, database.User{})

		// given
		if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, ""); true {
		require.NoError(t, err)
		}
		if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, ""); true {
		require.NoError(t, err)
		}
		if _, err := enq.Enqueue(ctx, user.UserID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "false"}, ""); true {
		require.NoError(t, err)
		}
		_, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, "")
		require.NoError(t, err)
		_, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, "")
		require.NoError(t, err)
		_, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "false"}, "")
		require.NoError(t, err)

		// when
		mgr.Run(ctx)
Expand DownExpand Up		@@ -94,7 +89,6 @@ func TestBuildPayload(t *testing.T) {
		"my_url": func() string { return url },
		}

		ctx := context.Background()
		db := dbmem.New()
		interceptor := newEnqueueInterceptor(db,
		// Inject custom message metadata to influence the payload construction.
Expand All		@@ -107,7 +101,7 @@ func TestBuildPayload(t *testing.T) {
		},
		}
		out, err := json.Marshal(actions)
		require.NoError(t, err)
		assert.NoError(t, err)

		return database.FetchNewMessageMetadataRow{
		NotificationName: "My Notification",
Expand All		@@ -122,19 +116,17 @@ func TestBuildPayload(t *testing.T) {
		enq, err := notifications.NewStoreEnqueuer(defaultNotificationsConfig(database.NotificationMethodSmtp), interceptor, helpers, logger.Named("notifications-enqueuer"))
		require.NoError(t, err)

		ctx := testutil.Context(t, testutil.WaitShort)

		// when
		_, err = enq.Enqueue(ctx, uuid.New(), notifications.TemplateWorkspaceDeleted, nil, "test")
		require.NoError(t, err)

		// then
		select {
		case payload := <-interceptor.payload:
		require.Len(t, payload.Actions, 1)
		require.Equal(t, label, payload.Actions[0].Label)
		require.Equal(t, url, payload.Actions[0].URL)
		case <-time.After(testutil.WaitShort):
		t.Fatalf("timed out")
		}
		payload := testutil.RequireRecvCtx(ctx, t, interceptor.payload)
		require.Len(t, payload.Actions, 1)
		require.Equal(t, label, payload.Actions[0].Label)
		require.Equal(t, url, payload.Actions[0].URL)
		}

		func TestStopBeforeRun(t *testing.T) {
Expand DownExpand Up		@@ -184,10 +176,6 @@ type santaHandler struct {
		nice atomic.Int32
		}

		func (*santaHandler) NotificationMethod() database.NotificationMethod {
		return database.NotificationMethodSmtp
		}

		func (s *santaHandler) Dispatcher(payload types.MessagePayload, _, _ string) (dispatch.DeliveryFunc, error) {
		return func(ctx context.Context, msgID uuid.UUID) (retryable bool, err error) {
		if payload.Labels["nice"] != "true" {
Expand Down