Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Group subcommands for cognitive ease#1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromseparatecmd
May 9, 2022
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedMay 9, 2022
edited
Loading

Fixes#1324.

I removed the ASCII logo too. It was cool, but not worth the prime real estate.

image

@kylecarbskylecarbs requested a review fromcoadlerMay 9, 2022 20:43
@kylecarbskylecarbs self-assigned thisMay 9, 2022
@kylecarbskylecarbs requested a review fromammarioMay 9, 2022 20:57
@codecov
Copy link

codecovbot commentedMay 9, 2022
edited
Loading

Codecov Report

Merging#1351 (8ea93b2) intomain (f5693df) willincrease coverage by0.32%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1351      +/-   ##==========================================+ Coverage   66.58%   66.90%   +0.32%==========================================  Files         284      280       -4       Lines       18593    18466     -127       Branches      235      235              ==========================================- Hits        12380    12355      -25+ Misses       4950     4845     -105- Partials     1263     1266       +3
FlagCoverage Δ
unittest-go-macos-latest54.06% <100.00%> (+0.33%)⬆️
unittest-go-postgres-65.64% <100.00%> (+0.49%)⬆️
unittest-go-ubuntu-latest56.48% <100.00%> (+0.21%)⬆️
unittest-go-windows-202252.42% <100.00%> (+0.35%)⬆️
unittest-js73.67% <ø> (ø)
Impacted FilesCoverage Δ
cli/autostart.go75.29% <100.00%> (+0.29%)⬆️
cli/configssh.go69.06% <100.00%> (+0.45%)⬆️
cli/create.go56.95% <100.00%> (+0.28%)⬆️
cli/delete.go25.00% <100.00%> (+5.76%)⬆️
cli/list.go9.52% <100.00%> (+2.96%)⬆️
cli/login.go55.85% <100.00%> (+0.23%)⬆️
cli/publickey.go76.92% <100.00%> (+0.92%)⬆️
cli/root.go79.43% <100.00%> (+0.29%)⬆️
cli/server.go57.58% <100.00%> (+0.07%)⬆️
cli/show.go23.07% <100.00%> (+6.41%)⬆️
... and15 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef5693df...8ea93b2. Read thecomment docs.

Comment on lines 21 to 23
Annotations: map[string]string{
"workspace": "",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Annotations:map[string]string{
"workspace":"",
},
Annotations:workspaceCommand,

@kylecarbskylecarbs merged commitddb9631 intomainMay 9, 2022
@kylecarbskylecarbs deleted the separatecmd branchMay 9, 2022 22:42
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

@ammarioammarioAwaiting requested review from ammario

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Group subcommands better for cognitive ease
3 participants
@kylecarbs@coadler@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp