NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: added contributor#1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Kira-Pilot merged 1 commit intomainfromadd-new-contributor/kira-pilot

May 9, 2022

Merged

chore: added contributor#1349

Kira-Pilot merged 1 commit intomainfromadd-new-contributor/kira-pilot

May 9, 2022

Conversation

Copy link

Member

Kira-Pilot commentedMay 9, 2022

Adding myself as a contributor! Also learning how to spell 🙃

chore: added contributer

ad33945

Kira-Pilot requested a review froma team

May 9, 2022 18:30

presleyp approved these changes

May 9, 2022

View reviewed changes

Copy link

Contributor

presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉

Copy link

codecovbot commentedMay 9, 2022•
edited
Loading

Codecov Report

Merging#1349 (ad33945) intomain (ad8d9dd) willincrease coverage by0.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1349      +/-   ##==========================================+ Coverage   66.44%   66.46%   +0.01%==========================================  Files         284      284                Lines       18584    18593       +9       Branches      235      235              ==========================================+ Hits        12349    12358       +9+ Misses       4967     4965       -2- Partials     1268     1270       +2

Flag	Coverage Δ
unittest-go-macos-latest	`53.70% <ø> (-0.01%)`	⬇️
unittest-go-postgres-	`65.13% <ø> (+<0.01%)`	⬆️
unittest-go-ubuntu-latest	`56.23% <ø> (+0.21%)`	⬆️
unittest-go-windows-2022	`52.05% <ø> (-0.02%)`	⬇️
unittest-js	`73.67% <ø> (ø)`

Impacted Files	Coverage Δ
codersdk/roles.go	`72.72% <0.00%> (-7.92%)`	⬇️
coderd/workspaceagents.go	`56.04% <0.00%> (-1.87%)`	⬇️
coderd/provisionerdaemons.go	`62.47% <0.00%> (-1.01%)`	⬇️
provisionerd/provisionerd.go	`76.17% <0.00%> (-0.94%)`	⬇️
coderd/roles.go	`100.00% <0.00%> (ø)`
codersdk/users.go	`65.17% <0.00%> (ø)`
site/src/testHelpers/entities.ts	`100.00% <0.00%> (ø)`
coderd/users.go	`61.74% <0.00%> (+0.38%)`	⬆️
cli/cliui/provisionerjob.go	`78.57% <0.00%> (+2.14%)`	⬆️
provisioner/echo/serve.go	`59.20% <0.00%> (+2.40%)`	⬆️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatead8d9dd...ad33945. Read thecomment docs.