Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore!: remove deprecated agent v1 routes#13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 6, 2024•
edited
Loading

This breaks compatibility with older agents that don't use API v2

Closes#10530

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson changed the titlechore: remove deprecated agent v1 routeschore!: remove deprecated agent v1 routesJun 6, 2024
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Looks good so far, but the metricscollector_test should be added back

ethanndickson reacted with laugh emoji
@ethanndicksonethanndickson marked this pull request as ready for reviewJune 6, 2024 15:54
@deansheatherdeansheather self-requested a reviewJune 8, 2024 11:32
@ethanndicksonethanndickson merged commitdd24368 intomainJun 11, 2024
29 of 31 checks passed
@ethanndicksonethanndickson deleted the 06-06-chore_remove_deprecated_agent_v1_routes branchJune 11, 2024 02:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 11, 2024
@f0ssel
Copy link
Contributor

FYI we probably need to mention this removal in the release docs @coder/pms

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Agent API v2 Support to Coderd
3 participants
@ethanndickson@f0ssel@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp