Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(coderd): set full name from IDP name claim#13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 11 commits intomainfromcj/idp-fullname
Jun 6, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 4, 2024
edited
Loading

Part of#11704

  • Updates OIDC and GitHub OAuth login to fetch set name from relevant claim fields
  • AddsCODER_OIDC_NAME_FIELD as configurable source of user name claim
  • Adds httpapi function to normalize a username such that it will pass validation
  • AddsfirstName /lastName fields to dev OIDC setup

Screenshots:

  1. Post-OIDC login:
    Screenshot 2024-06-06 at 11 39 20

  2. OIDC claims from DB:
    Screenshot 2024-06-06 at 11 49 54

NOTE: does not update "first-time setup" in the UI to allow setting username. This will be done in a separate PR.

bpmct and matifali reacted with heart emoji
@johnstcnjohnstcn self-assigned thisJun 4, 2024
@johnstcnjohnstcn changed the title[WIP] feat(coderd): set full name from IDPfeat(coderd): set full name from IDP name claimJun 6, 2024
@johnstcnjohnstcn marked this pull request as ready for reviewJune 6, 2024 10:53
@johnstcnjohnstcn requested review frommtojek,Emyrk anddannykopping and removed request formtojekJune 6, 2024 10:53
@johnstcnjohnstcn merged commit1131772 intomainJun 6, 2024
31 checks passed
@johnstcnjohnstcn deleted the cj/idp-fullname branchJune 6, 2024 12:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

@dannykoppingdannykoppingAwaiting requested review from dannykopping

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp