- Notifications
You must be signed in to change notification settings - Fork926
chore: external auth validate response "Forbidden" should return invalid, not an error#13446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emyrk commentedJun 3, 2024
| @@ -218,7 +218,7 @@ func (c *Config) ValidateToken(ctx context.Context, link *oauth2.Token) (bool, * | |||
| return false, nil, err | |||
| } | |||
| defer res.Body.Close() | |||
| if res.StatusCode == http.StatusUnauthorized { | |||
| if res.StatusCode == http.StatusUnauthorized|| res.StatusCode == http.StatusForbidden{ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the fix. Everything else is just unit testing
kylecarbs approved these changesJun 3, 2024
27f2691 intomain 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
User reported unable to delete a workspace because idp was returning a 403 on external auth Validate.
What this does
Prior to this change a 401 (unauthorized) yields an invalid token. 403s (forbidden) were counted as errors. Now both 401 and 403 yield unauthorized.
Not other 400 status codes would still yield an error and fail the workspace build.