Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add cleanup callbacks to someuseEffect calls#13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromeffect-cleanup
Jun 4, 2024

Conversation

aslilac
Copy link
Member

Closes#13422

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!
Had some comments about possibly making the code more clear, but that doesn't have anything to do with what you wrote. Everything right now is 100% an improvement

@aslilacaslilac merged commit0ea89a3 intomainJun 4, 2024
28 checks passed
@aslilacaslilac deleted the effect-cleanup branchJune 4, 2024 18:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Clean up buggyuseEffect calls
2 participants
@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp