Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: correct swagger description for Insights API#13442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intomainfrom12036-insights
Jun 3, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJun 3, 2024•
edited
Loading

Fixes:#12036

Screenshot 2024-06-03 at 15 23 16Screenshot 2024-06-03 at 15 27 36

@mtojekmtojek self-assigned thisJun 3, 2024
@mtojekmtojek marked this pull request as ready for reviewJune 3, 2024 13:45
@mtojekmtojek requested a review fromdannykoppingJune 3, 2024 13:45
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Did you update this manually or with a script?
If the latter, I'd suggest adding a linter so we can prevent a reoccurrence.

@mtojek
Copy link
MemberAuthor

Did you update this manually or with a script?

Manually in// @Param comments, we generate docs andswagger.json out of them. Unfortunately, there is no generator that understands our request params/body/headers. Maybe one day...

@mtojekmtojek merged commitbf98b0d intomainJun 3, 2024
32 checks passed
@mtojekmtojek deleted the 12036-insights branchJune 3, 2024 13:48
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insights API has incorrect swagger documentation
2 participants
@mtojek@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp