Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: rename notification banners to announcement banners#13419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 5 commits intomainfromannouncement-banners
May 31, 2024

Conversation

aslilac
Copy link
Member

No description provided.

@stirby
Copy link
Collaborator

Do you see any issue with leaving the internal symbols as NotificationBanner?

@aslilac
Copy link
MemberAuthor

Do you see any issue with leaving the internal symbols as NotificationBanner?

I kind of assumed that we'd already published a release with this feature, which would make renaming stuff in the code a breaking change, but I just double checked and realized that we haven't. It'd actually be a good idea to rename it more thoroughly, I just didn't realize I could. 😄

stirby reacted with thumbs up emoji

@stirby
Copy link
Collaborator

Ahh gotcha, appreciate you playing it safe 😁. The code freezeis tomorrow but I can cherry pick this in if you need time for the rename. 👍

@aslilac
Copy link
MemberAuthor

I think it should be ready to go!

@aslilacaslilac merged commitb248f12 intomainMay 31, 2024
31 checks passed
@aslilacaslilac deleted the announcement-banners branchMay 31, 2024 16:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 31, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@stirbystirbystirby approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@stirby

[8]ページ先頭

©2009-2025 Movatter.jp