- Notifications
You must be signed in to change notification settings - Fork927
chore: rename notification banners to announcement banners#13419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Do you see any issue with leaving the internal symbols as NotificationBanner? |
I kind of assumed that we'd already published a release with this feature, which would make renaming stuff in the code a breaking change, but I just double checked and realized that we haven't. It'd actually be a good idea to rename it more thoroughly, I just didn't realize I could. 😄 |
Ahh gotcha, appreciate you playing it safe 😁. The code freezeis tomorrow but I can cherry pick this in if you need time for the rename. 👍 |
I think it should be ready to go! |
b248f12
intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.