Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: upgrade to git v2.45.1 to fix alpine 3.20 builds#13411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intocoder:mainfromdannykopping:dk/fix-alpine-build
May 30, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedMay 30, 2024•
edited
Loading

Possiblyfixes#13407

Edit for clarity: the build works locally on my machine™️ but there may be other issues lurking, hence "probably".

Possiblyfixescoder#13407Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping changed the titleUpgrade to git v2.45.1 to fix alpine 3.20 buildschore: upgrade to git v2.45.1 to fix alpine 3.20 buildsMay 30, 2024
@matifali
Copy link
Member

Please rebase once#13409 is merged so that it can be tested :)

@dannykopping
Copy link
ContributorAuthor

Please rebase once#13409 is merged so that it can be tested :)

When is that likely to get merged?

@deansheather
Copy link
Member

Have you tried this build locally first?

@dannykopping
Copy link
ContributorAuthor

Have you tried this build locally first?

Yup, it works.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@johnstcn
Copy link
Member

Is there a reason we pin the git version at all?

@dannykoppingdannykopping marked this pull request as ready for reviewMay 30, 2024 08:35
@dannykoppingdannykoppingenabled auto-merge (squash)May 30, 2024 08:35
@dannykoppingdannykopping merged commita1671a6 intocoder:mainMay 30, 2024
31 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 30, 2024
@dannykopping
Copy link
ContributorAuthor

Whoops@matifali I had this on auto-merge but I see you just merged#13409, and you said you wanted to test with that too.

@dannykoppingdannykopping deleted the dk/fix-alpine-build branchMay 30, 2024 08:37
@dannykopping
Copy link
ContributorAuthor

dannykopping commentedMay 30, 2024•
edited
Loading

Is there a reason we pin the git version at all?

@johnstcn it was first done 2 weeks ago by@coadler:#13299
Seems like there was an RCE vuln.

@dannykopping
Copy link
ContributorAuthor

dannykopping commentedMay 30, 2024•
edited
Loading

Looks like 3.20 includes theversion I hardcoded, so I think it's probably safe to remove the pinning.

I'll create a follow-up PR.
#13414

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifalimatifali approved these changes

@coadlercoadlerAwaiting requested review from coadler

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-base build is failing since bumping alpine to 3.20
4 participants
@dannykopping@matifali@deansheather@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp