Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: build base image on PRs#13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 4 commits intomainfrombuild-base-on-pr
May 30, 2024
Merged

ci: build base image on PRs#13409

matifali merged 4 commits intomainfrombuild-base-on-pr
May 30, 2024

Conversation

matifali
Copy link
Member

This will prevent events like#13407 in future.

@ammario@kylecarbs, we should probably also mark this as a required workflow.

This will prevent events like#13407 in future.@ammario@kylecarbs, we should probably also mark this as a required workflow.
@matifalimatifali changed the titleci: builld base image on PRsci: build base image on PRsMay 30, 2024
deansheather

This comment was marked as resolved.

Do not push on `pull_request`
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is blocking my preview deployment as well, it seems:https://github.com/coder/coder/actions/runs/9299191579/job/25592636303

@matifali
Copy link
MemberAuthor

This is blocking my preview deployment as well, it seems:coder/coder/actions/runs/9299191579/job/25592636303

@dannykopping for this, we need to solve#13407. This PR will only prevent this in the future.

@dannykopping
Copy link
Contributor

This is blocking my preview deployment as well, it seems:coder/coder/actions/runs/9299191579/job/25592636303

@dannykopping for this, we need to solve#13407. This PR will only prevent this in the future.

Let's see if#13411 fixes it.

matifali reacted with rocket emoji

@matifalimatifali merged commit6730c24 intomainMay 30, 2024
24 checks passed
@matifalimatifali deleted the build-base-on-pr branchMay 30, 2024 08:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 30, 2024
@dannykopping
Copy link
Contributor

@dannykopping
Copy link
Contributor

If you don't already, I'd suggest testing workflows withhttps://github.com/nektos/act

@matifali
Copy link
MemberAuthor

@dannykopping Yes. Looking into it. Sorry for not testing it.

@dannykopping
Copy link
Contributor

No prob, let's revert in the interim pls

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

@coadlercoadlerAwaiting requested review from coadler

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@matifali@dannykopping@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp