Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): add deployment menu to navbar#13401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 7 commits intomainfromdeployment-menu
Jun 3, 2024
Merged

Conversation

aslilac
Copy link
Member

Screenshot 2024-05-29 at 3 04 20 PM

A small part of the multi-org work

canViewDeployment={canViewDeployment}
canViewAllUsers={canViewAllUsers}
canViewHealth={canViewHealth}
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if we can pass the root permissions to the component instead of creating derived values for each option.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

eh, I don't mind this. the root permissions names are a lot less clear imo, so having theNavbar "controller" abstract them with better names is nice.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In terms of design, the current one is ok but I would make the region and deployment menu buttons rounded to have the same style keeping them consistent.

About the code, just minor comments. Good work! 👍

@aslilacaslilac merged commit78b8264 intomainJun 3, 2024
@aslilacaslilac deleted the deployment-menu branchJune 3, 2024 21:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp