- Notifications
You must be signed in to change notification settings - Fork952
feat(site): add deployment menu to navbar#13401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
canViewDeployment={canViewDeployment} | ||
canViewAllUsers={canViewAllUsers} | ||
canViewHealth={canViewHealth} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wonder if we can pass the root permissions to the component instead of creating derived values for each option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
eh, I don't mind this. the root permissions names are a lot less clear imo, so having theNavbar
"controller" abstract them with better names is nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In terms of design, the current one is ok but I would make the region and deployment menu buttons rounded to have the same style keeping them consistent.
About the code, just minor comments. Good work! 👍
A small part of the multi-org work