Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(scripts): handle renamed cherry-pick commits in release script#13395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedMay 29, 2024•
edited
Loading

This came up for the next release:

❯ ./scripts/release/check_commit_metadata.sh v2.11.2 5789ea5397c080058e254e3d7aa895fb5e95ad16Checking commit metadata for changes between v2.11.2 and 5789ea5397c080058e254e3d7aa895fb5e95ad16...ERROR: Invariant failed, cherry-picked commits have different titles: chore: generate terraform testdata with matching terraform version (#13343) != ci: disable make test-migrations in release.yaml (#13201)

Fix:

Checking commit metadata for changes between v2.11.2 and 5789ea5397c080058e254e3d7aa895fb5e95ad16...Invariant failed, cherry-picked commits have different titles: chore: generate terraform testdata with matching terraform version (#13343) != ci: disable make test-migrations in release.yaml (#13201), attempting to check commit body for cherry-pick information...Not a cherry-pick commit, adding 3364abecdd8bbbf89a82d073d2b405fc623bb174 to pending list...Invariant failed, cherry-picked commits have different titles: fix: properly detect agent resouces in terraform (#13343) != , attempting to check commit body for cherry-pick information...Found renamed cherry-pick commit 9c5fc3bbbb77a08ebe5cfd5de3bdd4a2e8cbc547 -> 3364abecdd8bbbf89a82d073d2b405fc623bb174Checking if pending commit 3364abecdd8bbbf89a82d073d2b405fc623bb174 has a corresponding cherry-pick...Found matching cherry-pick commit 3364abecdd8bbbf89a82d073d2b405fc623bb174 -> 9c5fc3bbbb77a08ebe5cfd5de3bdd4a2e8cbc547

@mafredrimafredri self-assigned thisMay 29, 2024
@mafredrimafredri requested review fromcoadler andstirbyMay 29, 2024 17:53
@mafredrimafredriforce-pushed themafredri/chore-handle-renamed-cherry-picks-in-release-script branch fromfa79be2 to253c2e5CompareMay 29, 2024 17:55
@mafredrimafredriforce-pushed themafredri/chore-handle-renamed-cherry-picks-in-release-script branch from253c2e5 toae6db2dCompareMay 29, 2024 17:57
Copy link
Collaborator

@stirbystirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you 👑

@mafredrimafredri merged commit374f0a0 intomainMay 29, 2024
30 checks passed
@mafredrimafredri deleted the mafredri/chore-handle-renamed-cherry-picks-in-release-script branchMay 29, 2024 18:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler approved these changes

@stirbystirbystirby approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@coadler@stirby
[8]ページ先頭
©2009-2025 Movatter.jp