Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(site): refactor filters#13394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
BrunoQuaresma wants to merge27 commits intomainfrombq/improve-template-filter

Conversation

BrunoQuaresma
Copy link
Collaborator

I started to refactor our filters to make them easier to maintain. The current abstraction is not ideal. I'm opening this PR to collect early feedback.

Related to#13035

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like this new approach a lot! Had a couple of suggestions here and there, but I think the core logic looks really nice

It looks like this isn't fully done yet (some components not being integrated, somedebugger statements still being in the code), but let me know when you want me to do another review

BrunoQuaresma reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 7, 2024
@BrunoQuaresmaBrunoQuaresma removed the staleThis issue is like stale bread. labelJun 7, 2024
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 11, 2024
@github-actionsgithub-actionsbot deleted the bq/improve-template-filter branchDecember 8, 2024 00:07
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ParkreinerParkreinerParkreiner left review comments

@aslilacaslilacAwaiting requested review from aslilacaslilac will be requested when the pull request is marked ready for reviewaslilac is a code owner

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrunoQuaresma@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp