- Notifications
You must be signed in to change notification settings - Fork921
chore: move stat reporting into workspacestats package#13386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
johnstcn approved these changesMay 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, and the tests also appear to be happy.
It's nice that we now have unified behaviour between the legacy HTTP and dRPC agent APIs.
Uh oh!
There was an error while loading.Please reload this page.
5789ea5 intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Part of#13279
workspaceapps.StatsDBReporterin favor of newworkspacestats.Reporterworkspaceapps.StatsReporterinterface method name for clarityworkspaceapps.StatsCollectornow usesworkspacestats.Reporter.ReportAppStats()workspacestats.Reporter.ReportAgentStats()This is primarily just moving code, the only functional change here is that the legacy agent API routes previously only bumped
last_used_atif there was a tracked "session connection"`, but this diverges from our new agent API where we always bump it. The behavior is now unified to always bump the field since the legacy API is on the way out.