Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: transform underscores to hyphens for github login#13384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromghentusername
Jun 11, 2024

Conversation

kylecarbs
Copy link
Member

Fixes#13339.

@kylecarbskylecarbs self-assigned thisMay 28, 2024
@kylecarbskylecarbs requested a review frommafredriMay 28, 2024 16:14
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Scary to think what might happen if there issome_user andsome-user 😬.

@kylecarbs
Copy link
MemberAuthor

I'd like to think that's the edge-case of an edge-case, but maybe not...

@johnstcn
Copy link
Member

I'd like to think that's the edge-case of an edge-case, but maybe not...

Yeah, I think it would be a good call to have a test case for this so the behaviour is at least 'documented' as such.

@Emyrk
Copy link
Member

Scary to think what might happen if there issome_user andsome-user 😬.

At least their uid on the GH side would be different. Which is what we use for account link lookup iirc

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 6, 2024
@kylecarbskylecarbs reopened thisJun 11, 2024
@kylecarbskylecarbsenabled auto-merge (squash)June 11, 2024 13:26
@kylecarbskylecarbs merged commitc9cca9d intomainJun 11, 2024
27 checks passed
@kylecarbskylecarbs deleted the ghentusername branchJune 11, 2024 13:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@kylecarbskylecarbs

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Is there a way to change forced username format in Coder OSS
4 participants
@kylecarbs@johnstcn@Emyrk@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp