Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add refresh token and error to user's external auth page#13380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 7 commits intomainfromstevenmasley/external_auth_error
May 28, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMay 28, 2024•
edited
Loading

Closes#13381

What this does

We have 2 fields,has_refresh_token andvalidate_error on external authentication links that are not being exposed to the UI. Multiple users have asked how to determine if refresh tokens are being returned from the IDP.

This allows more user self serve for debugging.

has_refresh_token icon

A little "refresh" icon shown as an avatar badge with tooltip if the link has a refresh token.

Screenshot from 2024-05-28 13-36-44

Validate error

Displays the error below the link. (Ignore my typo of "Refresh")

Screenshot from 2024-05-28 09-32-18

Future work

Can probably be styled better in the future.

@EmyrkEmyrk changed the titlechore: add story for failed refresh errorchore: add refresh token and error to user's external auth pageMay 28, 2024
@EmyrkEmyrk requested review fromaslilac andBrunoQuaresma and removed request foraslilacMay 28, 2024 16:09
@EmyrkEmyrk marked this pull request as ready for reviewMay 28, 2024 16:09
@BrunoQuaresma
Copy link
Collaborator

I like the idea, but using the refresh icon directly on top of the provider icon does not have enough contrast so you can wrap it with a circular badge like the following image.
Circle Badge

You can look at theMUI Badge docs, and how they can be styled, andused with other elements.

As a secondary option, that does not look that good compared with the first option, you can use pills close to the action button.

Pill

Emyrk and MrPeacockNLB reacted with thumbs up emoji

@Emyrk
Copy link
MemberAuthor

Circle Badge

I really like this. The error and the refresh icon are actually not related. I'll give it a go at replicating that picture 👍

@EmyrkEmyrk merged commit6293c33 intomainMay 28, 2024
28 checks passed
@EmyrkEmyrk deleted the stevenmasley/external_auth_error branchMay 28, 2024 19:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External auth user settings page should include the debug informationvalidate_error andhas_refresh_token
2 participants
@Emyrk@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp