Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: stop logging workspace agent unless verbose#13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedMay 28, 2024•
edited
Loading

Output fromcoder speedtest,coder port-forward andcoder ping includes logging from thetailnet.Conn, which doesn't really match the plain, human readable text output of these commands. E.g.

2024-05-28 10:09:50.898 [info]  updating engine DERP map  derp_map="{\"Regions\":{\"1000\":{\"EmbeddedRelay\":false,\"RegionID\":1000,\"RegionCode\":\"coder_stun_1000\",\"RegionName\":\"Coder STUN 1000\",\"Nodes\":[{\"Name\":\"1000stun0\",\"RegionID\":1000,\"HostName\":\"stun.l.google.com\",\"STUNPort\":19302,\"STUNOnly\":true}]},\"1001\":{\"EmbeddedRelay\":false,\"RegionID\":1001,\"RegionCode\":\"coder_stun_1001\",\"RegionName\":\"Coder STUN 1001\",\"Nodes\":[{\"Name\":\"1001stun0\",\"RegionID\":1001,\"HostName\":\"stun1.l.google.com\",\"STUNPort\":19302,\"STUNOnly\":true}]},\"10013\":{\"EmbeddedRelay\":false,\"RegionID\":10013,\"RegionCode\":\"coder_paris-fly\",\"RegionName\":\"Europe Fly.io (Paris)\",\"Nodes\":[{\"Name\":\"10013a\",\"RegionID\":10013,\"HostName\":\"paris.fly.dev.coder.com\",\"STUNPort\":-1,\"DERPPort\":443}]},\"10015\":{\"EmbeddedRelay\":false,\"RegionID\":10015,\"RegionCode\":\"coder_sydney-fly\",\"RegionName\":\"Australia Fly.io (Sydney)\",\"Nodes\":[{\"Name\":\"10015a\",\"RegionID\":10015,\"HostName\":\"sydney.fly.dev.coder.com\",\"STUNPort\":-1,\"DERPPort\":443}]},\"10016\":{\"EmbeddedRelay\":false,\"RegionID\":10016,\"RegionCode\":\"coder_sao-paulo-fly\",\"RegionName\":\"Brazil Fly.io (Sao Paulo)\",\"Nodes\":[{\"Name\":\"10016a\",\"RegionID\":10016,\"HostName\":\"sao-paulo.fly.dev.coder.com\",\"STUNPort\":-1,\"DERPPort\":443}]},\"10018\":{\"EmbeddedRelay\":false,\"RegionID\":10018,\"RegionCode\":\"coder_johannesburg-fly\",\"RegionName\":\"South Africa Fly.io (Johannesburg)\",\"Nodes\":[{\"Name\":\"10018a\",\"RegionID\":10018,\"HostName\":\"jnb.fly.dev.coder.com\",\"STUNPort\":-1,\"DERPPort\":443}]},\"1002\":{\"EmbeddedRelay\":false,\"RegionID\":1002,\"RegionCode\":\"coder_stun_1002\",\"RegionName\":\"Coder STUN 1002\",\"Nodes\":[{\"Name\":\"1002stun0\",\"RegionID\":1002,\"HostName\":\"stun2.l.google.com\",\"STUNPort\":19302,\"STUNOnly\":true}]},\"1003\":{\"EmbeddedRelay\":false,\"RegionID\":1003,\"RegionCode\":\"coder_stun_1003\",\"RegionName\":\"Coder STUN 1003\",\"Nodes\":[{\"Name\":\"1003stun0\",\"RegionID\":1003,\"HostName\":\"stun3.l.google.com\",\"STUNPort\":19302,\"STUNOnly\":true}]},\"1004\":{\"EmbeddedRelay\":false,\"RegionID\":1004,\"RegionCode\":\"coder_stun_1004\",\"RegionName\":\"Coder STUN 1004\",\"Nodes\":[{\"Name\":\"1004stun0\",\"RegionID\":1004,\"HostName\":\"stun4.l.google.com\",\"STUNPort\":19302,\"STUNOnly\":true}]},\"999\":{\"EmbeddedRelay\":true,\"RegionID\":999,\"RegionCode\":\"coder\",\"RegionName\":\"Council Bluffs, Iowa\",\"Nodes\":[{\"Name\":\"999b\",\"RegionID\":999,\"HostName\":\"dev.coder.com\",\"STUNPort\":-1,\"DERPPort\":443}]}}}"2024-05-28 10:09:50.898 [info]  updating engine network map  network_map="netmap: self: [bqyfb] auth=machine-unknown u=? [fd7a:115c:a1e0:46da:b312:5e11:ec77:f271/128]\n"2024-05-28 10:09:50.899 [info]  updating engine filter  filter="&{logf:0x103ce9170 local:0x140007a0060 logIPs:0x140007a0078 matches4:[{IPProto:[6 17 1 58 132] Srcs:[{ip:{addr:{hi:0 lo:281470681743360} z:0x1400000e078} bitsPlusOne:1}] Dsts:[{Net:{ip:{addr:{hi:0 lo:281470681743360} z:0x1400000e078} bitsPlusOne:1} Ports:{First:0 Last:65535}}] Caps:[]}] matches6:[{IPProto:[6 17 1 58 132] Srcs:[{ip:{addr:{hi:0 lo:0} z:0x1400000e090} bitsPlusOne:1}] Dsts:[{Net:{ip:{addr:{hi:0 lo:0} z:0x1400000e090} bitsPlusOne:1} Ports:{First:0 Last:65535}}] Caps:[]}] cap4:[] cap6:[] state:0x14000788930 shieldsUp:false}"2024-05-28 10:09:52.067 [info]  updating engine network map  network_map="netmap: self: [bqyfb] auth=machine-unknown u=? [fd7a:115c:a1e0:46da:b312:5e11:ec77:f271/128]\n [W+fRR] d:52eb7800464fe556 D999 fd7a:115c:a1e0:4f25:bb75:b198:9e47:ea4e/128 fd7a:115c:a1e0:49d6:b259:b7ac:b1b2:48f4/128 :      3.19.66.22:33328      10.1.2.106:33328\n"209ms via coderStarting a 5s download test...INTERVAL       THROUGHPUT0.00-1.53 sec  10.9499 Mbits/sec1.53-2.62 sec  76.8738 Mbits/sec2.62-3.68 sec  79.7098 Mbits/sec3.68-4.73 sec  79.7699 Mbits/sec4.73-5.36 sec  79.3592 Mbits/sec----------------------------------0.00-5.36 sec  59.4535 Mbits/sec2024-05-28 10:10:00.341 [info]  closing tailnet Conn2024-05-28 10:10:00.342 [info]  closing tailnet Conn

I don't think we should be writing logs out to stderr unless--verbose is set.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedMay 28, 2024•
edited
Loading

@spikecurtisspikecurtis marked this pull request as ready for reviewMay 28, 2024 10:34
@spikecurtisspikecurtisforce-pushed the05-28-fix_respect_--disable-direct-connections_on_coder_speedtest branch fromd917514 tof82e76fCompareMay 29, 2024 03:56
@spikecurtisspikecurtisforce-pushed the05-28-fix_stop_logging_workspace_agent_unless_verbose branch fromda0e62c toe1e2cdeCompareMay 29, 2024 03:57
Base automatically changed from05-28-fix_respect_--disable-direct-connections_on_coder_speedtest tomainMay 29, 2024 04:07
@spikecurtisspikecurtisforce-pushed the05-28-fix_stop_logging_workspace_agent_unless_verbose branch frome1e2cde tobc6e4ffCompareMay 29, 2024 04:08
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedMay 29, 2024•
edited
Loading

Merge activity

  • May 29, 12:08 AM EDT:Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 29, 12:17 AM EDT:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis merged commit84b3121 intomainMay 29, 2024
27 checks passed
@spikecurtisspikecurtis deleted the 05-28-fix_stop_logging_workspace_agent_unless_verbose branchMay 29, 2024 04:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@coadler@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp