- Notifications
You must be signed in to change notification settings - Fork927
fix: respect --disable-direct-connections on coder speedtest#13377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
spikecurtis merged 1 commit intomainfrom05-28-fix_respect_--disable-direct-connections_on_coder_speedtestMay 29, 2024
Merged
fix: respect --disable-direct-connections on coder speedtest#13377
spikecurtis merged 1 commit intomainfrom05-28-fix_respect_--disable-direct-connections_on_coder_speedtestMay 29, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
deansheather approved these changesMay 28, 2024
coadler approved these changesMay 28, 2024
d917514 tof82e76fComparea551aa5 intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Spotted during code read.
coder speedtestnever setsBlockEndpointseven when--disable-direct-connectionsis set at the command root. This PR fixes this oversight.