		data "coder_workspace_tags" "custom_workspace_tags" {
		tags = {
		"zone" = "developers"
		"os" = data.coder_parameter.os_selector.value
		"project_id" = "PROJECT_${data.coder_parameter.project_name.value}"
		"cache" = data.coder_parameter.feature_cache_enabled.value == "true" ? "with-cache" : "no-cache"
		}
		}

		data "coder_parameter" "os_selector" {
		name = "os_selector"
		display_name = "OS runtime"
		default = "linux"

		option {
		name = "Linux"
		value = "linux"
		}
		option {
		name = "OSX"
		value = "osx"
		}
		option {
		name = "Windows"
		value = "windows"
		}

		mutable = false
		}

Copy link

Member

matifaliMay 23, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you explain ifdata.coder_parameter.os_selector represents the os of the workspace being provisioned? This example confuses me in understanding the purpose and benefits of usingworkspace_tags. If yes, then thecode-server and thedocker_container can only run on a Linux host. This feels incomplete on how a template can provide a workspace with three different OS using the new functionality and external-provisioners.

As this will also be published as an official example onhttps://registry.coder.com/templates, we should try to make the tags as practical as possible.

Copy link

Member

matifaliMay 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can remove the example altogether, too.

Copy link

MemberAuthor

mtojekMay 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Renamed theos_selector toruntime_selector, so it might be easier to comprehend that is about selecting either a free zone or an isolated, secure, air-gapped environment. I hope it makes it clear.

BTW I can modify it to depend on "foobars" too. My intention was to indicate the syntax rather providing use cases.

Copy link

Member

matifaliMay 23, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is better. But my opinion is that we should remove the example altogether if it is not usable out of the box. The docs are written well enough to serve the users who actually need to use this feature.

mtojek added3 commits

May 23, 2024 14:46

lacks

b43d8a1

rephrased

883a17d

rename os to runtime

cfd0c23

johnstcn approved these changes

May 23, 2024

View reviewed changes

docs/templates/workspace-tags.md OutdatedShow resolvedHide resolved

docs/templates/workspace-tags.mdShow resolvedHide resolved

docs/manifest.json Outdated

		@@ -200,6 +200,11 @@
		"description": "Prompt the template administrator for additional information about a template",
		"path": "./templates/variables.md"
		},
		{
		"title": "Workspace Tags",
		"description": "Select provisioners using Coder Parameters",

Copy link

Member

johnstcnMay 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

SEO suggestion:

Suggested change

	"description":"Select provisioners usingCoder Parameters",
	"description":"Control provisioning usingWorkspace Tags and Parameters",

Copy link

MemberAuthor

mtojekMay 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's a good hint!

Cian's review

12a292c

Copy link

Member

matifali commentedMay 23, 2024•
edited
Loading

@johnstcn To dogfood this, I suggest we run provisioners on all dogfood regions and useworkspace_tags to choose regions.

Copy link

MemberAuthor

mtojek commentedMay 23, 2024

@matifali I'm happy to discuss improvements in docs, examples, and product expectations once you're back from PTO. It is hard to chat about plans here.