May 17, 2024 · May 17, 2024 · May 17, 2024 · May 17, 2024 · May 17, 2024
diff --git a/Makefile b/Makefile
 test-migrations: test-postgres-docker
 echo "--- test migrations"
 set -euo pipefail
 COMMIT_FROM=$(shell git rev-parse --short HEAD)
 COMMIT_TO=$(shell git rev-parse --short main)
 COMMIT_FROM=$(shell git log -1 --format='%h' HEAD)
 echo "COMMIT_FROM=$${COMMIT_FROM}"
 COMMIT_TO=$(shell git log -1 --format='%h' origin/main)
 echo "COMMIT_TO=$${COMMIT_TO}"
 if [[ "$${COMMIT_FROM}" == "$${COMMIT_TO}" ]]; then echo "Nothing to do!"; exit 0; fi
 echo "DROP DATABASE IF EXISTS migrate_test_$${COMMIT_FROM}; CREATE DATABASE migrate_test_$${COMMIT_FROM};" | psql 'postgresql://postgres:postgres@localhost:5432/postgres?sslmode=disable'
 go run ./scripts/migrate-test/main.go --from="$$COMMIT_FROM" --to="$$COMMIT_TO" --postgres-url="postgresql://postgres:postgres@localhost:5432/migrate_test_$${COMMIT_FROM}?sslmode=disable"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -797,8 +797,11 @@ test-postgres: test-postgres-docker
		test-migrations: test-postgres-docker
		echo "--- test migrations"
		set -euo pipefail
		COMMIT_FROM=$(shell git rev-parse --short HEAD)
		COMMIT_TO=$(shell git rev-parse --short main)
		COMMIT_FROM=$(shell git log -1 --format='%h' HEAD)
Copy link Member mafredriMay 17, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Why short-form, btw? I guess it's more human friendly, but the long-form is more robust. Copy link MemberAuthor johnstcnMay 17, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I was initially worried about exceeding the maximum name length of a database name, but it looks like we're under the 63 byte limit even with the long identifier.
		echo "COMMIT_FROM=$${COMMIT_FROM}"
Copy link Member mafredriMay 17, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Pro-tip:`declare` is pretty nice (`declare -p COMMIT_FROM COMMIT_TO`. Not necessarily for here, but future reference. johnstcn reacted with thumbs up emoji
		COMMIT_TO=$(shell git log -1 --format='%h' origin/main)
		echo "COMMIT_TO=$${COMMIT_TO}"
		if [[ "$${COMMIT_FROM}" == "$${COMMIT_TO}" ]]; then echo "Nothing to do!"; exit 0; fi
		echo "DROP DATABASE IF EXISTS migrate_test_$${COMMIT_FROM}; CREATE DATABASE migrate_test_$${COMMIT_FROM};" \| psql 'postgresql://postgres:postgres@localhost:5432/postgres?sslmode=disable'
		go run ./scripts/migrate-test/main.go --from="$$COMMIT_FROM" --to="$$COMMIT_TO" --postgres-url="postgresql://postgres:postgres@localhost:5432/migrate_test_$${COMMIT_FROM}?sslmode=disable"

Expand Down