Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Fix dependabot path after moving package.json into site#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bryphe-coder merged 2 commits intomainfrombryphe/fix/dependabot-path
Feb 1, 2022

Conversation

bryphe-coder
Copy link
Contributor

Missed in#128 - need to update thedependabot.yml to point to the correct package.json, which was moved from/package.json ->/site/package.json

@bryphe-coderbryphe-coder self-assigned thisFeb 1, 2022
@codecov
Copy link

codecovbot commentedFeb 1, 2022•
edited
Loading

Codecov Report

Merging#133 (6694969) intomain (177eba8) willdecrease coverage by0.09%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #133      +/-   ##==========================================- Coverage   70.41%   70.32%   -0.10%==========================================  Files         100      100                Lines        4317     4317                Branches       68       68              ==========================================- Hits         3040     3036       -4- Misses       1029     1032       +3- Partials      248      249       +1
FlagCoverage Δ
unittest-go-macos-latest67.92% <ø> (-0.42%)⬇️
unittest-go-ubuntu-latest70.00% <ø> (-0.14%)⬇️
unittest-go-windows-latest68.07% <ø> (+0.17%)⬆️
unittest-js64.62% <ø> (ø)
Impacted FilesCoverage Δ
provisionerd/provisionerd.go75.67% <0.00%> (-1.09%)⬇️
peer/conn.go76.82% <0.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update177eba8...6694969. Read thecomment docs.

@bryphe-coder
Copy link
ContributorAuthor

Thanks@jawnsy@kylecarbs for reviewing!

@bryphe-coderbryphe-coder merged commit56b3ec1 intomainFeb 1, 2022
@bryphe-coderbryphe-coder deleted the bryphe/fix/dependabot-path branchFebruary 1, 2022 22:44
bryphe-coder added a commit that referenced this pull requestFeb 1, 2022
…139)Unfortunately along with#133 I missed one other item in moving files to `/site` in#128 - ignoring new configuration files (and other folders) in our `jest.config.js`.This caused our coverage numbers in front-end code to dip, because files that shouldn't be included (and previously weren't included) were now being tracked for coverage.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

+1 more reviewer

@jawnsyjawnsyjawnsy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryphe-coder@jawnsy@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp