Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add basic organization management ui#13288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 24 commits intomainfromorg-management-ui
Jun 17, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedMay 15, 2024•
edited
Loading

Screenshot 2024-06-13 at 10 42 49 AM

It's not completely fleshed out, but it's behind an experiment and gives us something to build on.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 24, 2024
@aslilacaslilac reopened thisJun 3, 2024
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJun 4, 2024
@aslilacaslilac changed the titlefeat(site): wip org management uifeat(site): basic org management uiJun 11, 2024
@aslilacaslilac changed the titlefeat(site): basic org management uifeat(site): add basic organization management uiJun 11, 2024
@aslilacaslilac marked this pull request as ready for reviewJune 13, 2024 16:44
export default OrganizationSettingsPage;

const styles = {
dangerButton: (theme) => ({
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresmaJun 14, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If the current style for danger buttons is not good enough, I think we should apply the changes in the mui styles to make it consistent across the UI.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I copied it from the delete dialog. This is gonna get reworked and removed later.

BrunoQuaresma reacted with thumbs up emoji
href: string;
}

export const SidebarNavItem: FC<SidebarNavItemProps> = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we have a set of common components to build a sidebar. If not, we probably should make them to keep it consistent.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we do, but the styling of the sidebar in this view needs to be quite different from our existing sidebars. we can see if there's a nice way to unify them later. I tried using them initially, but it's a lot easier to iterate this way for now.

BrunoQuaresma reacted with thumbs up emoji
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left a few comments and I'm missing tests for the new additions.

@BrunoQuaresma
Copy link
Collaborator

A few UX findings:

  • I would expect the sidebar to use the org display name if it is available
  • I would expect to see a success notification when saving the settings

@aslilac
Copy link
MemberAuthor

I would expect the sidebar to use the org display name if it is available

It already does.

BrunoQuaresma reacted with thumbs up emoji

@BrunoQuaresma
Copy link
Collaborator

I was able to create an org and I'm leaving a few considerations even knowing some of them may be out of the scope of this PR.

The create org form is below the fold
When I tried the first time, I didn't see the form because I didn't notice it was below the fold. Maybe we could add a "Create organization" in the sidebar that can open a modal with the form.

Screenshot 2024-06-17 at 10 50 55

Validation

  • The validation is not clear about the error
  • I'm missing a space from the alert and form
  • When focusing on the alert, I have to scroll down to see the form again
  • We should have a help text for the name saying it does not accept special characters
Screenshot 2024-06-17 at 10 50 47

Create org
We can display a success alert and reset the scroll to the top.

Delete org

  • We can display an icon button with a "trash" icon on the right of the name or below.
  • Show a confirmation dialog.

@aslilac
Copy link
MemberAuthor

Creating and deleting orgs is going to get entirely redone.

BrunoQuaresma reacted with thumbs up emoji

@aslilacaslilac merged commit8c1bd32 intomainJun 17, 2024
30 checks passed
@aslilacaslilac deleted the org-management-ui branchJune 17, 2024 17:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp