Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: push rbac actions to policy package#13274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromstevenmasley/rego_to_policy
May 15, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMay 14, 2024•
edited
Loading

Just movedrbac.Action ->policy.Action. This is for the stacked PR to not have circular dependencies when doing autogen. Without this, the autogen can produce broken golang code, which prevents the autogen from compiling.

So just avoiding circular dependencies. Doing this in it's own PR to reduce LoC diffs in the primary PR, since this has 0 functional changes.

@EmyrkGraphite App
Copy link
MemberAuthor

Emyrk commentedMay 14, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@Emyrk and the rest of your teammates onGraphiteGraphite

@EmyrkEmyrkforce-pushed thestevenmasley/rego_to_policy branch 2 times, most recently from9f50b1b to46dbb72CompareMay 14, 2024 20:08
Moving to support more verbs. It is easier to keep the verbs intheir own package for autogen reasons. Autogen will generate contentin the rbac package. If the verbs are in the rbac package, thenthe autogen can fail if the autogen produces no-valid go code.It's a circular dependency that this commit avoids
@EmyrkEmyrkforce-pushed thestevenmasley/rego_to_policy branch from46dbb72 tob2f9524CompareMay 14, 2024 22:00
@EmyrkEmyrk marked this pull request as ready for reviewMay 15, 2024 00:04
@EmyrkGraphite App
Copy link
MemberAuthor

Emyrk commentedMay 15, 2024•
edited
Loading

Merge activity

  • May 15, 10:46 AM EDT:@Emyrk started a stack merge that includes this pull request viaGraphite.
  • May 15, 10:46 AM EDT:@Emyrk merged this pull request withGraphite.

@EmyrkEmyrk merged commitcb6b5e8 intomainMay 15, 2024
30 checks passed
@EmyrkEmyrk deleted the stevenmasley/rego_to_policy branchMay 15, 2024 14:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp