- Notifications
You must be signed in to change notification settings - Fork1k
chore: expose all organization ids from AuthContext#13268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| const[activeOrganizationId,setActiveOrganizationId]=useState(()=> | ||
| lastUsedOrganizationId&&organizationIds.includes(lastUsedOrganizationId) | ||
| ?lastUsedOrganizationId | ||
| :organizationIds[0], | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Talked to@aslilac, we are not going to introduce the concept of "Default Org" to the FE. It is a stop gap on the backend to accommodate features like group sync, role sync, SCIM, etc. Those features need to be upgraded to not rely on default org.
If a deployment exists with more than 1 org, this is no morebroken than it currently is today.
| if(!organizationIds.includes(id)){ | ||
| thrownewReferenceError("Invalid organization ID"); | ||
| } | ||
| localStorage.setItem(`user:${user.id}.lastUsedOrganizationId`,id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Smart assigning to a user!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good changes 🙏
Uh oh!
There was an error while loading.Please reload this page.
The important bit of this change is in AuthContext.tsx and DashboardProvider.tsx:
AuthContextnow exposes anorganizationIdsproperty, which is a list, rather than theorganizationIdproperty, which was a single ID.DashboardContextis now responsible for managing the state around which organization should be "active" in the app.The rest is just "to whom it may concern" updates to accommodate those changes.
Also, some of these usages of
organizationIdare almost certainly incorrect, but I'd rather audit all of that in a separate PR.