Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(site): fix group badge visual#13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/fix-group-badge
May 14, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Just used abutton to simplify styling.

Closes#13069

Copy link
Member

@ParkreinerParkreiner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not fully clear on what the original issue has highlighting – I'm guessing that the interactive area for the Groups content was really small, and wasn't filling out the entire table cell. Is that basically right?

Just want to make sure before I give the approval

@BrunoQuaresma
Copy link
CollaboratorAuthor

Basically in the light mode, there is a box shadow around the button that is strange.

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes make sense to me!

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresma merged commitf149279 intomainMay 14, 2024
28 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-group-badge branchMay 14, 2024 16:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users page > groups bubbles have insufficient padding
2 participants
@BrunoQuaresma@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp