- Notifications
You must be signed in to change notification settings - Fork928
fix: check if context is nil when logging coordination delete errors#13192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'm not exactly sure how to handle this idiomatically...See:https://github.com/coder/coder/actions/runs/8976564938/job/24653672411
@spikecurtis we could check directly for the |
Really, we shouldn't even be starting a PGCoordinator to test the licensing APIs of Coderd. This is a canonical example of a test that is doing way to much and so errors in an unrelated part of the code are causing it to flake. That said, PGCoordinator doesn't have a synchronous |
c.f.#13192 (comment)We need to wait for PGCoordinator to finish its work before returning on `Close()`, so that we delete database state (best effort -- if this fails others will filter it out based on heartbeats).
I'm not exactly sure how to handle this idiomatically...
See:https://github.com/coder/coder/actions/runs/8976564938/job/24653672411