- Notifications
You must be signed in to change notification settings - Fork928
feat: Add support for json omitempty and embedded structs in apitypings#1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 6 commits intomafredri/feat-paginate-template-versions-endpointfrommafredri/feat-improve-generated-typingsMay 10, 2022
Merged
feat: Add support for json omitempty and embedded structs in apitypings#1318
mafredri merged 6 commits intomafredri/feat-paginate-template-versions-endpointfrommafredri/feat-improve-generated-typingsMay 10, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedMay 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## mafredri/feat-paginate-template-versions-endpoint #1318 +/- ##======================================================================================- Coverage 66.78% 56.52% -10.26%====================================================================================== Files 282 152 -130 Lines 18471 16624 -1847 Branches 235 0 -235 ======================================================================================- Hits 12335 9397 -2938- Misses 4866 6128 +1262+ Partials 1270 1099 -171
Continue to review full report at Codecov.
|
presleyp approved these changesMay 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks great, thanks!
coadler approved these changesMay 6, 2022
Uh oh!
There was an error while loading.Please reload this page.
deansheather approved these changesMay 6, 2022
Uh oh!
There was an error while loading.Please reload this page.
04b3b1f to13fc406CompareOtherwise changes in the apitypings generator are not detected.
ccade36 to3650ed7Comparemafredri added a commit that referenced this pull requestMay 10, 2022
…1308)* feat: Implement pagination for template versions* feat: Use unified pagination between users and template versions* Sync codepaths between users and template versions* Create requestOption type in codersdk and add test* Fix created_at edge case for pagination cursor in queries* feat: Add support for json omitempty and embedded structs in apitypings (#1318)* Add scripts/apitypings/main.go to Makefile
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
…1308)* feat: Implement pagination for template versions* feat: Use unified pagination between users and template versions* Sync codepaths between users and template versions* Create requestOption type in codersdk and add test* Fix created_at edge case for pagination cursor in queries* feat: Add support for json omitempty and embedded structs in apitypings (#1318)* Add scripts/apitypings/main.go to Makefile
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR targets#1308, it is a continuation but I felt it warranted a separate PR.
This PR adds support for the JSON
omitemptytag (reflected as a TypeScript optional) and embedded structs in thecodersdkpackage. The properties of embedded structs now appear directly on the struct that embeds them via TypeScriptinterface .. extends. This behaves the same way as the Gojson.Marshalandjson.Unmarshaldo when a struct is embedded (example playground).As discussed in#1308 (comment), the generated typings are not ideal for comfortable use in the frontend, this tries to amend that.
If we don't want the above behavior, the field can either be named or a have
jsontag added.Do these changes seem reasonable/are they helpful@presleyp@BrunoQuaresma?